8000 Serialize Vamana index with SSD sector alignment per MSFT DiskANN format, generate quantized dataset for integration with DiskANN by jamxia155 · Pull Request #846 · rapidsai/cuvs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Serialize Vamana index with SSD sector alignment per MSFT DiskANN format, generate quantized dataset for integration with DiskANN #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 51 commits into
base: branch-25.08
Choose a base branch
from

Conversation

jamxia155
Copy link

(This supersedes PR!703)

Added an optional input flag to cuvs::neighbors::vamana::serialize to dump an input cuvs Vamana index to file with SSD sector alignment. File format follows MSFT DiskANN.

Using the sector-aligned option also writes out the quantized dataset computed using user-supplied PQ codebooks file and rotation matrix file.

Copy link
copy-pr-bot bot commented Apr 25, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cjnolet
Copy link
Member
cjnolet commented Apr 25, 2025

/ok to test d0aabc6

@jamxia155 jamxia155 marked this pull request as ready for review April 25, 2025 20:08
@jamxia155 jamxia155 requested a review from a team as a code owner April 25, 2025 20:08
@github-actions github-actions bot removed the ci label Jun 2, 2025
@cjnolet
Copy link
Member
cjnolet commented Jun 10, 2025

@jamxia155 I sincerely apologize for the delayed response here. We had some critical issues for release 25.06 that took several folks from the team over a week to resolve. Good news is that the release is now complete and we're available to help with timely reviews and guidance.

I notice the last several commits are related to the cmake download of the test files. These will need to work both locally for users, as well as in CI. Are they working locally for you?

@jamxia155
Copy link
Author
jamxia155 commented Jun 10, 2025

I notice the last several commits are related to the cmake download of the test files. These will need to work both locally for users, as well as in CI. Are they working locally for you?

Hi @cjnolet, those changes worked locally for me but are not working in the CI yet. However, I have since received helpful guidance from @bdice on the pattern that's currently used in cuGraph and I think I have a good handle on what needs to be done now. Thanks.

@github-actions github-actions bot added the ci label Jun 10, 2025
@divyegala
Copy link
Member

Approving binary size addition to libcuvs.so of ~8.3 MB given the feature importance. @bkarsin @jamxia155 to file a follow-on issue to work on identifying any potential for size reduction.

@jamxia155 jamxia155 requested a review from tarang-jain June 18, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
Development

Successfully merging this pull request may close these issues.

7 participants
0