8000 Use random tmp names for index files in tests by achirkin · Pull Request #837 · rapidsai/cuvs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use random tmp names for index files in tests #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

Use random tmp names for index files in tests #837

merged 3 commits into from
Apr 24, 2025

Conversation

achirkin
Copy link
Contributor

Replace all hard-coded index file names in tests with a randomly-generated unique paths in the system temporary folder and delete the files after use.

This is a slightly opinionated convenience PR to give the following benefits:

  • Temporary index files do not clutter the project folder
  • One can run multiple test instances in parallel without the danger of data corruption (e.g. for stress-testing)
  • The tests do not fail if the current folder is read-only

@achirkin achirkin added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Apr 23, 2025
@achirkin achirkin self-assigned this Apr 23, 2025
@achirkin achirkin requested a review from a team as a code owner April 23, 2025 08:40
@github-actions github-actions bot added the cpp label Apr 23, 2025
@achirkin
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c3a77ec into rapidsai:branch-25.06 Apr 24, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@achirkin achirkin

Labels
cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
Vector Search, ML, & Data Mining Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achirkin @cjnolet
0