Support passing a dataset to FromCagra
#767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR looks good to me but is there a reason we are attempting to merge it to |
|
Nope, we need to carry this forward to 25.04. No more features can be merged into 25.02. Thanks for reviewing @divyegala! |
|
@ajit283 please re-target to 25.04 and I will approve this PR |
|
/ok to test |
divyegala
approved these changes
Mar 15, 2025
<
8000
/div>
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/merge |
jiangyinzuo
pushed a commit
to jiangyinzuo/cuvs
that referenced
this pull request
May 25, 2025
For out-of-core CAGRA index builds where the dataset does not fit on GPU memory, a host tensor can be passed using this. Authors: - Ajit Mistry (https://github.com/ajit283) - Corey J. Nolet (https://github.com/cjnolet< 7BF1 /a>) - Divye Gala (https://github.com/divyegala) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For out-of-core CAGRA index builds where the dataset does not fit on GPU memory, a host tensor can be passed using this.