8000 Remove unused raft cagra header in add_nodes.cuh by jiangyinzuo · Pull Request #741 · rapidsai/cuvs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove unused raft cagra header in add_nodes.cuh #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2025
Merged

Remove unused raft cagra header in add_nodes.cuh #741

merged 4 commits into from
May 29, 2025

Conversation

jiangyinzuo
Copy link
Contributor

Vector search headers in raft will be removed in the future, so we should not include the raft cagra header.

@jiangyinzuo jiangyinzuo requested a review from a team as a code owner March 1, 2025 08:21
@copy-pr-bot copy-pr-bot
Copy link
copy-pr-bot bot commented Mar 1, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the cpp label Mar 1, 2025
@cjnolet cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 1, 2025
@cjnolet
Copy link
Member
cjnolet commented Mar 1, 2025

/ok to test

1 similar comment
@cjnolet
Copy link
Member
cjnolet commented Mar 4, 2025

/ok to test

@jiangyin 8000 zuo
Remove unused raft cagra header in add_nodes.cuh
ec0845f 
Vector search headers in raft will be removed in the future, so we should not include the raft cagra header.
tarang-jain
tarang-jain reviewed Apr 18, 2025
View reviewed changes
Copy link
Contributor
@tarang-jain tarang-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase to 25.06?

@cjnolet cjnolet changed the base branch from branch-25.04 to branch-25.06 May 27, 2025 18:21
@cjnolet
Copy link
Member
cjnolet commented May 27, 2025

/ok to test 61652af

@cjnolet
Copy link
Member
cjnolet commented May 27, 2025

/merge

@cjnolet
Copy link
Member
cjnolet commented May 28, 2025

/ok to test 156125b

@cjnolet
Copy link
Member
cjnolet commented May 28, 2025

/merge

@rapids-bot rapids-bot bot merged commit 5460c62 into rapidsai:branch-25.06 May 29, 2025
75 checks passed
mythrocks pushed a commit to mythrocks/cuvs that referenced this pull request Jun 3, 2025
@jiangyinzuo @mythrocks
Remove unused raft cagra header in add_nodes.cuh (rapidsai#741)
510af19 
Vector search headers in raft will be removed in the future, so we should not include the raft cagra header.

Authors:
  - Yinzuo Jiang (https://github.com/jiangyinzuo)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarang-jain tarang-jain tarang-jain left review comments

@cjnolet cjnolet cjnolet approved these changes

Assignees

@jiangyinzuo jiangyinzuo

Labels
cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
Vector Search, ML, & Data Mining Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiangyinzuo @cjnolet @tarang-jain
0