Add shellcheck to pre-commit and fix warnings
#662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
jameslamb
approved these changes
Feb 5, 2025
| @@ -15,9 +15,6 @@ rapids-print-env | |||
|
|
|||
| rapids-logger "Begin py build" | |||
|
|
|||
| package_name="cuvs" | |||
| package_dir="python" | |||
| @@ -6,18 +6,17 @@ set -euo pipefail | |||
| package_dir=$1 | |||
| wheel_dir_relative_path=$2 | |||
|
|
|||
| RAPIDS_CUDA_MAJOR="${RAPIDS_CUDA_VERSION%%.*}" | |||
There was a problem hiding this comment.
Definitely looks like something I left behind in #594 , thanks for fixing it.
|
/merge |
divyegala
pushed a commit
to divyegala/cuvs
that referenced
this pull request
Feb 12, 2025
`shellcheck` is a fast, static analysis tool for shell scripts. It's good at flagging up unused variables, unintentional glob expansions, and other potential execution and security headaches that arise from the wonders of `bash` (and other shlangs). This PR adds a `pre-commit` hook to run `shellcheck` on all of the `sh-lang` files in the `ci/` directory, and the changes requested by `shellcheck` to make the existing files pass the check. xref: rapidsai/build-planning#135 Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - James Lamb (https://github.com/jameslamb) URL: rapidsai#662
rapids-bot bot
pushed a commit
that referenced
this pull request
May 2, 2025
Contributes to rapidsai/build-planning#135 Follow-up to #662 While reviewing #805 and #831, I found myself suggesting things manually that I know `shellcheck` would have caught automatically. To prevent that for reviewers in the future, this proposes running `shellcheck` on **all** shell scripts in the repo, not just those in the `ci/` directory. Other changes: * updates `rapids-dependency-file-generator` to its latest version (1.18.1) * consolidates duplicate entries for https://github.com/pre-commit/pre-commit-hooks in `.pre-commit-config.yaml` Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) - Ben Frederickson (https://github.com/benfred) URL: #865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shellcheckis a fast, static analysis tool for shell scripts. It's good atflagging up unused variables, unintentional glob expansions, and other potential
execution and security headaches that arise from the wonders of
bash(andother shlangs).
This PR adds a
pre-commithook to runshellcheckon all of thesh-langfiles in the
ci/directory, and the changes requested byshellcheckto makethe existing files pass the check.
xref: rapidsai/build-planning#135