Quick fixes of modernize-use-constraints rule
#19105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
@vyasr I was not able to build pylibcudf with these changes, looks like some further CMake changes are needed. Do you know how to compile pylibcudf with C++20? |
…into constraints-quick-fix
This reverts commit 62104d2.
…into constraints-quick-fix
…into constraints-quick-fix
mhaseeb123
reviewed
Jun 10, 2025
| @@ -23,6 +23,8 @@ project( | |||
| VERSION "${RAPIDS_VERSION}" | |||
| LANGUAGES CXX CUDA | |||
| ) | |||
| set(CMAKE_CXX_STANDARD 20) | |||
There was a problem hiding this comment.
I wonder what CXX_STANDARD was it using before?
There was a problem hiding this comment.
No idea what the default is. Probably 17.
mhaseeb123
approved these changes
Jun 11, 2025
PointKernel
approved these changes
Jun 11, 2025
cpp/include/cudf/detail/iterator.cuh
Outdated
| __device__ inline rep_type get_rep(DeviceScalar const& dscalar) const | ||
| requires has_rep_member<DeviceScalar>::value |
There was a problem hiding this comment.
Should we enforce the use of parentheses for consistency?
There was a problem hiding this comment.
Looks like clang-format can't automate this :(
But, only 8 instances don't have parentheses, so I can do it manually.
As a side note, we can configure clang-format if we don't like current formatting of the requires clauses, but this can be done at any time FAICT.
ttnghia
approved these changes
Jun 11, 2025
ttnghia
approved these changes
Jun 11, 2025
|
Out of curiosity, did this PR have a meaningful impact on compile times? Constraints should in principle evaluate faster than SFINAE. |
pxLi
pushed a commit
to NVIDIA/spark-rapids-jni
that referenced
this pull request
Jun 12, 2025
C++20 standard has been adopted in libcudf and the breaking changes (code using C++20 standard) start to go in since rapidsai/cudf#19105. We need to upgrade our repository accordingly. Signed-off-by: Nghia Truong <nghiat@nvidia.com>
I've tested this PR (with |
|
/merge |
04b918a
into
rapidsai:branch-25.08
155 of 157 checks passed
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
While reviewing #19105, I noticed that the AST operators make extensive use of `std::` traits and utilities within device functions. This is suboptimal, as it depends on relaxed constexpr behavior and may lead to undefined behavior. This PR updates all such usages to their corresponding `cuda::std::` equivalents thus helping #7795. Authors: - Yunsong Wang (https://github.com/PointKernel) Approvers: - Nghia Truong (https://github.com/ttnghia) - MithunR (https://github.com/mythrocks) URL: #19179
sdrp713
added a commit
to sdrp713/spark-rapids-jni
that referenced
this pull request
Jul 1, 2025
commit 3ade001 Author: Rahul Prabhu <raprabhu@nvidia.com> Date: Tue Jul 1 09:38:39 2025 -0700 Fix Formatting commit 9ad8978 Merge: 0c1cb89 83648f2 Author: Rahul Prabhu <100436830+sdrp713@users.noreply.github.com> Date: Mon Jun 30 13:31:07 2025 -0700 Merge branch 'NVIDIA:branch-25.08' into branch-25.08 commit 0c1cb89 Author: Rahul Prabhu <raprabhu@nvidia.com> Date: Mon Jun 30 12:18:25 2025 -0700 Init Commit commit 83648f2 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Tue Jul 1 02:26:54 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3488) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: ed24fcf, cudf commit SHA: rapidsai/cudf@fbcb744 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 81ecee3 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Sat Jun 28 15:29:38 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3487) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 239dbb3, cudf commit SHA: rapidsai/cudf@22d1b7c This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 7cdbf66 Author: Nghia Truong <7416935+ttnghia@users.noreply.github.com> Date: Fri Jun 27 18:11:34 2025 -0700 Fix libcudf breaking changes with `grid_1d` (NVIDIA#3486) This fixes the breaking changes in libcudf regarding `grid_1d` refactor. Basically, this just include some headers into our code. --------- Signed-off-by: Nghia Truong <nghiat@nvidia.com> commit 269640d Author: Liangcai Li <firestarmanllc@gmail.com> Date: Sat Jun 28 09:10:50 2025 +0800 Expose the row index of one failed row when casting floats to decimals. (NVIDIA#3479) contributes to NVIDIA/spark-rapids#11550 This PR exposes the row index of one failed row when casting floats to decimals to replace the `has_failure`. This index will be used to get the row value which will be used to build the excepion message, to align with the behavior of Spark. Spark will return nulls for NaN, Infinity and -Infinity even the ANSI mode is on, so this PR also changes the code to follow the logic. --------- Signed-off-by: Firestarman <firestarmanllc@gmail.com> Co-authored-by: Nghia Truong <7416935+ttnghia@users.noreply.github.com> commit 9718bd4 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Fri Jun 27 21:31:33 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3485) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 75742c7, cudf commit SHA: rapidsai/cudf@a881a4a This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 1b61332 Author: Peixin <pxli@nyu.edu> Date: Fri Jun 27 11:24:31 2025 +0800 Update 25.08 cuda12 default to 12.9.1 (NVIDIA#3484) follow-up for rapidsai/cudf#19231 Signed-off-by: Peixin Li <pxLi@nyu.edu> commit 40b3774 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Fri Jun 27 08:30:18 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3483) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: a06ff66, cudf commit SHA: rapidsai/cudf@3ac130c This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit a7e1381 Author: Alessandro Bellina <abellina@nvidia.com> Date: Thu Jun 26 18:22:34 2025 -0500 Revert "scl default" changes made previously given CI failures (NVIDIA#3474) Closes NVIDIA#3299 The issue here looks to be that we are enabling a devtoolset from within a shell that already has devtoolset enabled. TableTest, in particularly, will shell out (invoking bash, see https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java#L852), and this is the stack where we hang. It looks that enabling toolsets should be done once, and this nested case may be error prone. I have reverted the change locally and cannot reproduce the hang anymore. I believe this to be the root cause of our hangs in CI. --------- Signed-off-by: Alessandro Bellina <abellina@nvidia.com> Signed-off-by: Nghia Truong <nghiat@nvidia.com> Co-authored-by: Nghia Truong <nghiat@nvidia.com> commit ccad147 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Fri Jun 27 05:34:06 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3482) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 18a5cdf, cudf commit SHA: rapidsai/cudf@5558e62 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 64763b0 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Fri Jun 27 01:30:20 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3481) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: d9e93c4, cudf commit SHA: rapidsai/cudf@b2a88f9 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 4cdb460 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Thu Jun 26 21:31:21 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3480) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 7db4c64, cudf commit SHA: rapidsai/cudf@4013c76 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 5e998dc Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Thu Jun 26 10:23:42 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3478) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: dd8e477, cudf commit SHA: rapidsai/cudf@b09a7c7 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 59a4bd9 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Thu Jun 26 08:31:05 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3477) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 8eda7e8, cudf commit SHA: rapidsai/cudf@7b536ee This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 15ef256 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Thu Jun 26 06:41:18 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3476) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 4e4c7b7, cudf commit SHA: rapidsai/cudf@9c90453 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 6baa281 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Thu Jun 26 01:30:09 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3475) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: a4b5398, cudf commit SHA: rapidsai/cudf@a217abc This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 46e34aa Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Wed Jun 25 22:41:20 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3473) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 40d662c, cudf commit SHA: rapidsai/cudf@3c1e4db This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit dbbbd15 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Wed Jun 25 12:40:43 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3472) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: e1c2cd6, cudf commit SHA: rapidsai/cudf@f6c2a1c This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 468706b Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Wed Jun 25 05:35:37 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3471) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 251b5ab, cudf commit SHA: rapidsai/cudf@bd518be This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 4b75375 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Wed Jun 25 01:31:57 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3470) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 6a7581b, cudf commit SHA: rapidsai/cudf@5b9d9a5 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 7f61495 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Thu Jun 19 15:31:26 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3469) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 5a9eed8, cudf commit SHA: rapidsai/cudf@ba20837 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 0e12cda Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Thu Jun 19 08:31:56 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3468) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: bdaeff6, cudf commit SHA: rapidsai/cudf@b9fb517 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit cbd9029 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Thu Jun 19 06:35:08 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3467) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: c51ac38, cudf commit SHA: rapidsai/cudf@5cbf34f This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 12f51f5 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Wed Jun 18 13:12:11 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3465) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 512a7d9, cudf commit SHA: rapidsai/cudf@60a6082 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 01e1768 Author: Nghia Truong <7416935+ttnghia@users.noreply.github.com> Date: Tue Jun 17 17:55:51 2025 -0700 Adopt changes in cudf JNI exception handling (NVIDIA#3449) This is to repeat a breaking change fix which was merged in NVIDIA#3375 but then reverted in NVIDIA#3412. Depends on: * rapidsai/cudf#19149 --------- Signed-off-by: Nghia Truong <nghiat@nvidia.com> commit 4c003a5 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Wed Jun 18 05:31:31 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3464) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 3ecb6d7, cudf commit SHA: rapidsai/cudf@77d0757 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit b1b5fc7 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Wed Jun 18 01:31:02 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3462) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 3fcabdb, cudf commit SHA: rapidsai/cudf@63a88ef This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 1b9a508 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Tue Jun 17 15:31:39 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3461) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 7e2d78a, cudf commit SHA: rapidsai/cudf@98a69e9 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 4c60d76 Author: Peixin <pxli@nyu.edu> Date: Tue Jun 17 09:43:23 2025 +0800 Use shared auto-merge workflow [skip ci] (NVIDIA#3460) follow-up of NVIDIA#3459 as we stop auto-merge as the same strategy as rapids team. Port the change to 25.08 <img width="500" alt="image" src="https://github.com/user-attachments/assets/d7ebfb2d-df41-43d6-ab61-ac3827c38485" /> Signed-off-by: Peixin Li <pxLi@nyu.edu> commit 753da51 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Tue Jun 17 08:31:02 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3458) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 975ab08, cudf commit SHA: rapidsai/cudf@971e7fc This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit a9d77de Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Tue Jun 17 06:35:53 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3457) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: d174a0e, cudf commit SHA: rapidsai/cudf@4466e55 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 2688e5f Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Tue Jun 17 01:31:19 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3456) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 60e91b7, cudf commit SHA: rapidsai/cudf@b49728e This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit c89789f Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Sat Jun 14 15:31:22 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3455) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 7d92fb8, cudf commit SHA: rapidsai/cudf@386603b This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 025ff59 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Sat Jun 14 08:30:36 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3454) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: c4e7148, cudf commit SHA: rapidsai/cudf@6e7bd1c This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit a6ac6d5 Author: Nghia Truong <7416935+ttnghia@users.noreply.github.com> Date: Fri Jun 13 16:33:32 2025 -0700 Fix overflow in decimal scaling operation (NVIDIA#3452) When doing decimal scaling, the scale factor (256bit) is incorrectly cast into `int` value, which cannot hold the 256 bit value. This fixes it, keeping the 256bit value without casting for further operation. A new Java test is added to verify this. This also fixes a few memory leak issues in Java tests, and renames variables into a more accurate meaning. Closes NVIDIA#3451. --------- Signed-off-by: Nghia Truong <nghiat@nvidia.com> commit e19d362 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Sat Jun 14 05:31:22 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3453) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 6f5ddba, cudf commit SHA: rapidsai/cudf@a343c4d This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 7b73bbe Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Fri Jun 13 05:31:51 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3450) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 8c4cdd6, cudf commit SHA: rapidsai/cudf@e5ba330 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 9b3fa1e Author: Nghia Truong <7416935+ttnghia@users.noreply.github.com> Date: Thu Jun 12 12:56:02 2025 -0700 Fix benchmark to compile with C++20 standard (NVIDIA#3447) This upgrades C++20 standard for additional places which were not included in NVIDIA#3443. It also fixes a compile issue when building benchmark using C++20 standard. --------- Signed-off-by: Nghia Truong <nghiat@nvidia.com> commit 59605e4 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Fri Jun 13 01:31:59 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3448) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 7d872f0, cudf commit SHA: rapidsai/cudf@5d02e2b This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 12d73e5 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Thu Jun 12 16:49:26 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3446) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 3863787, cudf commit SHA: rapidsai/cudf@c0c8a50 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit eccdf4e Author: Nghia Truong <7416935+ttnghia@users.noreply.github.com> Date: Wed Jun 11 18:18:17 2025 -0700 Upgrade C++ standard to `C++20` (NVIDIA#3443) C++20 standard has been adopted in libcudf and the breaking changes (code using C++20 standard) start to go in since rapidsai/cudf#19105. We need to upgrade our repository accordingly. Signed-off-by: Nghia Truong <nghiat@nvidia.com> commit 5d0c6b6 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Thu Jun 12 08:40:14 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3445) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: f6b54b8, cudf commit SHA: rapidsai/cudf@42c65c0 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit ee2d4d7 Author: Chong Gao <chongg@nvidia.com> Date: Thu Jun 12 08:19:56 2025 +0800 Bump org.apache.parquet:parquet-avro from 1.10.0 to 1.15.2 (NVIDIA#3441) This is to replace NVIDIA#3214, because I can not update PR3214 Signed-off-by: Chong Gao <res_life@163.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Chong Gao <res_life@163.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chong Gao <res_life@163.com> commit 65ef690 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Thu Jun 12 05:31:19 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3444) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 46d3a5a, cudf commit SHA: rapidsai/cudf@99d0d9b This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit b229530 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Thu Jun 12 02:41:47 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3442) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 0d7693d, cudf commit SHA: rapidsai/cudf@ca6e9e7 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 46d92a3 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Wed Jun 11 15:31:22 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3440) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: cf73f0b, cudf commit SHA: rapidsai/cudf@22d0345 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> commit 4706745 Author: Jenkins Automation <70000568+nvauto@users.noreply.github.com> Date: Wed Jun 11 08:35:49 2025 +0800 [submodule-sync] bot-submodule-sync-branch-25.08 to branch-25.08 [skip ci] [bot] (NVIDIA#3439) submodule-sync to create a PR keeping thirdparty/cudf up-to-date. HEAD commit SHA: 26806a1, cudf commit SHA: rapidsai/cudf@c66be16 This PR will be auto-merged if test passed. If failed, it will remain open until test pass or manually fix. --------- Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applied quick fixes of the
modernize-use-constraintsrule, which suggests use of the requires clause instead of SFINAE.This covers around half of the SFINAE use, so follow up PR will be needed.
Skipped cases where SFINAE is used alongside template specialization, because wheels builds (GCC 11) segfault in such cases.
Skipped changes to the public APIs because of issues with docs.
Checklist