Fix device compression when writing Parquet files without using nvCOMP #18644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
vuule
commented
May 2, 2025
| @@ -58,7 +58,7 @@ enum class usage_policy : uint8_t { OFF, STABLE, ALWAYS }; | |||
| */ | |||
| usage_policy get_env_policy() | |||
| { | |||
| static auto const env_val = getenv_or<std::string>("LIBCUDF_NVCOMP_POLICY", "STABLE"); | |||
| auto const env_val = getenv_or<std::string>("LIBCUDF_NVCOMP_POLICY", "STABLE"); | |||
There was a problem hiding this comment.
not static to enable testing
|
/ok to test |
…ule/cudf into bug-kernel-comp-write_parquet
shrshi
reviewed
May 2, 2025
shrshi
approved these changes
May 5, 2025
ttnghia
approved these changes
May 5, 2025
mhaseeb123
approved these changes
May 5, 2025
|
/merge |
vyasr
added a commit
to vyasr/cudf
that referenced
this pull request
May 6, 2025
…ng nvCOMP (rapidsai#18644)" This reverts commit 8ece12e.
3 tasks
|
forgot to link when opened, let's try now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue in the Parquet writer where all compression would fail when device compression with internal kernels is used.
Root cause is that a compressed chunk size was not being set, as it's not required for the nvCOMP implementation.
Expanded a few tests to use internal kernels for compression; planning to make more extensive test changes to improve test coverage of compression/decompression internal kernels in a separate PR.
Checklist