Implemented String Input support for Transforms and Removed jit::column_device_view
#18378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
jit::column_device_view
davidwendt
reviewed
Apr 1, 2025
bdice
reviewed
Apr 3, 2025
…rrr/cudf into column-device-view-refactor
3 tasks
davidwendt
requested changes
Apr 14, 2025
There was a problem hiding this comment.
Should we move the get_mask_offset_word to the base.cuh file?
https://github.com/rapidsai/cudf/pull/18378/files#diff-6ac3de833fc4161021e4c6fb6e436587d8a09ed24f30d16dcda091f01f3c5817R796
|
@kingcrimsontianyu would you please share your review? |
davidwendt
reviewed
Apr 15, 2025
davidwendt
approved these changes
Apr 15, 2025
…rrr/cudf into column-device-view-refactor
kingcrimsontianyu
approved these changes
Apr 17, 2025
bdice
approved these changes
Apr 17, 2025
|
/merge |
copy-pr-bot bot
pushed a commit
that referenced
this pull request
May 15, 2025
…umn_device_view` (#18378) This merge request implements string transforms (input-only) and also refactors the `column_device_view` type to support usage in JITify code. Closes #18229 Follows up: #18023 Authors: - Basit Ayantunde (https://github.com/lamarrr) Approvers: - David Wendt (https://github.com/davidwendt) - Tianyu Liu (https://github.com/kingcrimsontianyu) - Bradley Dice (https://github.com/bdice) URL: #18378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge request implements string transforms (input-only) and also refactors the
column_device_viewtype to support usage in JITify code.Closes #18229
Follows up: #18023
Checklist