Handle empty dictionary in to_arrow_device interop #18121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
mythrocks
reviewed
Mar 6, 2025
mythrocks
reviewed
Mar 6, 2025
|
Do we also need to fix https://github.com/rapidsai/cudf/blob/branch-25.04/cpp/src/interop/to_arrow_host.cu#L245? |
vyasr
approved these changes
Mar 8, 2025
karthikeyann
approved these changes
Mar 10, 2025
| column)); | ||
|
|
||
| auto const dcv = cudf::dictionary_column_view(column); | ||
| auto const dict_indices = dcv.is_empty() ? cudf::make_empty_column(cudf::type_id::INT32)->view() |
There was a problem hiding this comment.
I suppose, empty column view pointers are all nullptr.
mythrocks
approved these changes
Mar 11, 2025
|
/merge |
5566e8d
into
rapidsai:branch-25.04
107 of 117 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt at fixing issue described here #18071 (comment)
Closes #18071
Checklist