8000 Prevent setting custom attributes to `ColumnMethods` by galipremsagar · Pull Request #18005 · rapidsai/cudf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prevent setting custom attributes to ColumnMethods #18005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 20, 2025
Merged

Prevent setting custom attributes to ColumnMethods #18005

merged 4 commits into from
Feb 20, 2025

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #17750

This PR disallows setting custom attributes to ColumnMethods

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug S 8000 omething isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. non-breaking Non-breaking change labels Feb 13, 2025
@galipremsagar galipremsagar self-assigned this Feb 13, 2025
@galipremsagar galipremsagar requested a review from a team as a code owner February 13, 2025 19:39
mroeschke
mroeschke approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor
@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a rebase otherwise LGTM

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 19, 2025
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit abffae8 into rapidsai:branch-25.04 Feb 20, 2025
128 of 129 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] .str should not allow adding any new attribute other than defined
2 participants
@galipremsagar @mroeschke
0