Fix possible OOB mem access in Parquet decoder #17841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mhaseeb123
commented
Jan 28, 2025
PointKernel
approved these changes
Jan 28, 2025
davidwendt
approved these changes
Jan 28, 2025
vuule
reviewed
Jan 28, 2025
| compute_initial_large_strings_offset( | ||
| s, initial_str_offsets[pages[page_idx].chunk_idx], has_repetition); | ||
| auto const chunks_per_rowgroup = initial_str_offsets.size(); | ||
| auto const input_col_idx = pages[page_idx].chunk_idx % chunks_per_rowgroup; |
There was a problem hiding this comment.
whoops! So, this worked by the grace of the memory pool?
There was a problem hiding this comment.
Yes, it seems like it. 😅
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17838. Related to #17702
This PR fixes a possible OOB in parquet string decoder when writing initial offset for nested large string cols. Existing tests should have been throwing segfaults in decoder kernels but somehow weren't. The decoder was producing correct results even without this change as the initial offsets are written from the first decoded ColumnChunk of each input column.
Checklist