8000 Fix groupby shift/diff/fill after selecting from a `GroupBy` by shwina · Pull Request #9984 · rapidsai/cudf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix groupby shift/diff/fill after selecting from a GroupBy #9984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 6, 2022
Merged

Fix groupby shift/diff/fill after selecting from a GroupBy #9984

merged 3 commits into from
Jan 6, 2022

Conversation

shwina
Copy link
Contributor
@shwina shwina commented Jan 6, 2022

Fixes #9969

Due to a bug in GroupBy.__getitem__, selecting a column of a GroupBy and then doing a shift, diff, or fill operation would result in the operation being performed on the wrong values. This PR fixes GroupBy.__getitem__ so we now have the right behaviour.

@shwina shwina requested a review from a team as a code owner January 6, 2022 18:17
@shwina shwina requested review from galipremsagar and isVoid January 6, 2022 18:17
@shwina shwina added the bug Something isn't working label Jan 6, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 6, 2022
@shwina shwina added non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Jan 6, 2022
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jan 6, 2022
isVoid
isVoid approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor
@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thnx!

@codecov
Copy link
codecov bot commented Jan 6, 2022 •
edited
Loading

Codecov Report

Merging #9984 (064b681) into branch-22.02 (967a333) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 064b681 differs from pull request most recent head d136cb4. Consider uploading reports for the commit d136cb4 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9984      +/-   ##
================================================
- Coverage         10.49%   10.45%   -0.04%     
================================================
  Files               119      119              
  Lines             20305    20414     +109     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18280     +105
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1de945...d136cb4. Read the comment docs.

@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 61199ea into rapidsai:branch-22.02 Jan 6, 2022
@takaiyuk takaiyuk mentioned this pull request Apr 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@isVoid isVoid isVoid approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Series group shift is not being performed on the correct columns
3 participants
@shwina @galipremsagar @isVoid
0