8000 Implement JNI for `cudf::scatter` APIs by ttnghia · Pull Request #9903 · rapidsai/cudf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement JNI for cudf::scatter APIs #9903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 15, 2021
Merged

Implement JNI for cudf::scatter APIs #9903

merged 9 commits into from
Dec 15, 2021

Conversation

ttnghia
Copy link
Contributor
@ttnghia ttnghia commented Dec 14, 2021 •
edited
Loading

This PR adds Java binding for both cudf::scatter APIs:

std::unique_ptr<table> scatter(
  table_view const& source,
  column_view const& scatter_map,
  table_view const& target,
...)

and

std::unique_ptr<table> scatter(
  std::vector<std::reference_wrapper<const scalar>> const& source,
  column_view const& indices,
  table_view const& target,
...)

Closes #9892.

@ttnghia ttnghia added feature request New feature or request 2 - In Progress Currently a work in progress 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Dec 14, 2021
@ttnghia ttnghia requested a review from jlowe December 14, 2021 21:57
@ttnghia ttnghia self-assigned this Dec 14, 2021
@ttnghia ttnghia requested a review from a team as a code owner December 14, 2021 21:57
jlowe
jlowe reviewed Dec 14, 2021
View reviewed changes
jlowe
jlowe reviewed Dec 14, 2021
View reviewed changes
Copy link
Contributor
@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the native method disconnect and add tests but otherwise is looking good

@ttnghia ttnghia removed the 2 - In Progress Currently a work in progress label Dec 15, 2021
@rapidsai rapidsai deleted a comment from codecov bot Dec 15, 2021
jlowe
jlowe reviewed Dec 15, 2021
View reviewed changes
@rapidsai rapidsai deleted a comment from codecov bot Dec 15, 2021
jlowe
jlowe reviewed Dec 15, 2021
View reviewed changes
@rapidsai rapidsai deleted a comment from codecov bot Dec 15, 2021
@rapidsai rapidsai deleted a comment from codecov bot Dec 15, 2021
@ttnghia
Copy link
Contributor Author
ttnghia commented Dec 15, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0faf2af into rapidsai:branch-22.02 Dec 15, 2021
@ttnghia ttnghia 7A35 deleted the jni_scatter branch December 15, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Java bindings for scatter
2 participants
@ttnghia @jlowe
0