8000 Fix compilation of benchmark for parquet writer. by bdice · Pull Request #9905 · rapidsai/cudf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix compilation of benchmark for parquet writer. #9905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 15, 2021
Merged

Fix compilation of benchmark for parquet writer. #9905

merged 3 commits into from
Dec 15, 2021

Conversation

bdice
Copy link
Contributor
@bdice bdice commented Dec 15, 2021 •
edited
Loading

This fixes a compilation error introduced in #9810. Tagging @devavret @vuule for review. Feel free to push to this PR with any fixes.

@bdice bdice requested a review from a team as a code owner December 15, 2021 01:00
@bdice bdice requested review from vyasr and jrhemstad December 15, 2021 01:00
@bdice bdice self-assigned this Dec 15, 2021
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 15, 2021
@bdice bdice added bug Something isn't working libcudf blocker labels Dec 15, 2021
@bdice bdice requested review from vuule and devavret December 15, 2021 01:01
vuule
vuule reviewed Dec 15, 2021
View reviewed changes
@bdice @vuule
Update cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp
524b309 
Co-authored-by: Vukasin Milovanovic <vukasin.milovanovic.87@gmail.com>
bdice
bdice commented Dec 15, 2021
View reviewed changes
@bdice bdice requested a review from vuule December 15, 2021 01:05
@bdice bdice added the non-breaking Non-breaking change label Dec 15, 2021
@codecov
Copy link
codecov bot commented Dec 15, 2021 •
edited
Loading

Codecov Report

Merging #9905 (e675d63) into branch-22.02 (967a333) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head e675d63 differs from pull request most recent head 3e73b4e. Consider uploading reports for the commit 3e73b4e to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9905      +/-   ##
================================================
- Coverage         10.49%   10.41%   -0.08%     
================================================
  Files               119      119              
  Lines             20305    20498     +193     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18364     +189
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc2a32a...3e73b4e. Read the comment docs.

@bdice
Copy link
Contributor Author
bdice commented Dec 15, 2021

Java CI is failing, seemingly because of another change from #9810. https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-java/CUDA=11.5,GPU_LABEL=gpu,LINUX_VER=centos7,PYTHON=3.7/3289/console

20:18:44      [exec] /workspace/java/src/main/native/src/TableJni.cpp: In function ‘void cudf::jni::{anonymous}::createTableMetaData(JNIEnv*, jint, _jobjectArray*&, _jintArray*&, _jbooleanArray*&, _jobjectArray*&, _jobjectArray*&, _jbooleanArray*&, _jintArray*&, _jbooleanArray*&, cudf::io::table_input_metadata&)’:
20:18:49      [exec] /workspace/java/src/main/native/src/TableJni.cpp:746:14: error: ‘class cudf::io::table_input_metadata’ has no member named ‘user_data’
20:18:49      [exec]   746 |     metadata.user_data[meta_keys[i].get()] = meta_values[i].get();
20:18:49      [exec]       |              ^~~~~~~~~
20:18:49      [exec] make[2]: *** [CMakeFiles/cudfjni.dir/build.make:286: CMakeFiles/cudfjni.dir/src/TableJni.cpp.o] Error 1

Points to this line:

cudf/java/src/main/native/src/TableJni.cpp

Line 746 in fc2a32a

metadata.user_data[meta_keys[i].get()] = meta_values[i].get();

...but the user_data field was removed in #9810.

@bdice
Copy link
Contributor Author
bdice commented Dec 15, 2021 •
edited
Loading

I think the Java CI fix is out of scope for this PR. I looked at it but it seems nontrivial and more deeply linked to the changes in #9810. Since #9810 was previously merged with this Java failure, I will merge this PR to fix the benchmark compilation error. The Java failure can be separately fixed.

@bdice
Copy link
Contributor Author
bdice commented Dec 15, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3428f7f into rapidsai:branch-22.02 Dec 15, 2021
@bdice bdice deleted the fix-benchmark-parquet-writer branch December 15, 2021 04:09
@bdice bdice mentioned this pull request Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@vuule vuule vuule approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@devavret devavret Awaiting requested review from devavret

Assignees

@bdice bdice

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice 337E @ttnghia @vuule
0