8000 Support re.Pattern object for pat arg in str.replace by davidwendt · Pull Request #9573 · rapidsai/cudf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support re.Pattern object for pat arg in str.replace #9573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Nov 2, 2021
Merged

Support re.Pattern object for pat arg in str.replace #9573

merged 26 commits into from
Nov 2, 2021

Conversation

davidwendt
Copy link
Contributor
@davidwendt davidwendt commented Nov 1, 2021 •
edited
Loading

Closes #7904

Depends on #9439

Adds support to accepting a pattern argument in cudf str.replace that is built using re.compile. The resulting re.Pattern has a member pattern that is the regex string that can be passed to libcudf. There is also flags member that can be used for libcudf APIs that accept a regex_flags parameter along with the pattern string.

@davidwendt
Add support for single-line regex anchors ^/$ in contains_re
3524163
@davidwendt
fix meta.yaml
bfb7b6c
@davidwendt
change default to !multiline
8690abe
@davidwendt
Merge branch 'branch-21.12' into fea-regex-flags
370099c
@davidwendt
add regex_flags to contains.pxd
ac43c6a
@davidwendt
fix isort style check failure in .pxd
d1e28e6
@davidwendt
pass regex flags through from python/cython
d9447ef
@davidwendt
update python and pytests for flags checking
96766d1
@davidwendt
add flags doc to string.py
5a8a2f6
@davidwendt
use rex values instead of hardcoded int
452c1ae
@davidwendt
Merge branch 'branch-21.12' into fea-regex-flags
93741c3
@davidwendt
import re (builtin) instead of regex
96d6e01
@davidwendt
remove duplicate import re
d3191f4
@davidwendt
fix merge conflict
d792a29
@davidwendt
add missing doxygen param
a2634f3
@davidwendt
change define to constexpr
8106b41
@davidwendt
check for unsupported flags
88cca5f
@davidwendt
Merge branch 'branch-21.12' into fea-regex-flags
bb8424b
@davidwendt
Merge branch 'branch-21.12' into fea-regex-flags
b685d5d
@davidwendt
fix misspelling of interpreting
dbf6f15
@davidwendt
change int32 to size-type
8ba74e8
@davidwendt
add flags parameter name
571afa8
@davidwendt
add _is_supported_regex_flags
3e9c390
@davidwendt
Merge branch 'branch-21.12' into fea-regex-flags
c8d6b56
@davidwendt
Support re.compile for pat arg in str.replace
7a4c1f7
@davidwendt davidwendt added feature request New feature or request 2 - In Progress Currently a work in progress Python Affects Python cuDF API. non-breaking Non-breaking change labels Nov 1, 2021
@davidwendt davidwendt self-assigned this Nov 1, 2021
@github-actions github-actions bot added conda libcudf Affects libcudf (C++/CUDA) code. labels Nov 1, 2021
@codecov
Copy link
codecov bot commented Nov 1, 2021 •
edited
Loading

Codecov Report

Merging #9573 (19e69b9) into branch-21.12 (ab4bfaa) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9573      +/-   ##
================================================
- Coverage         10.79%   10.65%   -0.14%     
================================================
  Files               116      117       +1     
  Lines             18869    19746     +877     
================================================
+ Hits               2036     2104      +68     
- Misses            16833    17642     +809
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e632f97...19e69b9. Read the comment docs.

@github-actions github-actions bot removed conda libcudf Affects libcudf (C++/CUDA) code. labels Nov 2, 2021
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 2, 2021
@davidwendt davidwendt marked this pull request as ready for review November 2, 2021 15:50
@davidwendt davidwendt requested a review from a team as a code owner November 2, 2021 15:50
@brandon-b-miller
Copy link
Contributor

LGTM

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 2, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8a5adad into rapidsai:branch-21.12 Nov 2, 2021
@davidwendt davidwendt deleted the fea-accept-compiled-re branch November 2, 2021 17:21
@davidwendt davidwendt mentioned this pull request Feb 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@marlenezw marlenezw Awaiting requested review from marlenezw marlenezw is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@davidwendt davidwendt

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Support accepting compiled regular expression objects from re.compile() as a pattern
3 participants
@davidwendt @brandon-b-miller @galipremsagar
0