8000 Add JNI for `lists::drop_list_duplicates` with keys-values input column by ttnghia · Pull Request #9553 · rapidsai/cudf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add JNI for lists::drop_list_duplicates with keys-values input column #9553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 12, 2021
Merged

Add JNI for lists::drop_list_duplicates with keys-values input column #9553

merged 14 commits into from
Nov 12, 2021

Conversation

ttnghia
Copy link
Contributor
@ttnghia ttnghia commented Oct 28, 2021 •
edited
Loading

This PR adds JNI work for the new interface of lists::drop_list_duplicates that operates on keys-values input columns. It also does a small fix to remove an unused variable in drop_list_duplicates.cu.

Blocked by #9345.

@ttnghia ttnghia added feature request New feature or request 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Oct 28, 2021
@ttnghia ttnghia requested review from andygrove and revans2 October 28, 2021 19:53
@ttnghia ttnghia self-assigned this Oct 28, 2021
@ttnghia ttnghia requested review from a team as code owners October 28, 2021 19:53
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 28, 2021
@ttnghia ttnghia force-pushed the jni_drop_list_duplicates branch from 8bc3c43 to 6697e22 Compare October 28, 2021 19:56
@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Oct 28, 2021
@ttnghia ttnghia removed the request for review from a team October 28, 2021 19:57
@ttnghia ttnghia added the DO NOT MERGE Hold off on merging; see PR for details label Oct 29, 2021
@andygrove andygrove mentioned this pull request Nov 2, 2021
Merged
@ttnghia ttnghia changed the title Add JNI for lists::drop_list_duplicates with keys-values input column [skip ci] Add JNI for lists::drop_list_duplicates with keys-values input column Nov 11, 2021
@ttnghia ttnghia removed the DO NOT MERGE Hold off on merging; see PR for details label Nov 11, 2021
@codecov
Copy link
codecov bot commented Nov 11, 2021 •
edited
Loading

Codecov Report

Merging #9553 (8a3c26d) into branch-21.12 (ab4bfaa) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 8a3c26d differs from pull request most recent head 2ef8b35. Consider uploading reports for the commit 2ef8b35 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9553      +/-   ##
================================================
- Coverage         10.79%   10.67%   -0.12%     
================================================
  Files               116      117       +1     
  Lines             18869    19884    +1015     
================================================
+ Hits               2036     2123      +87     
- Misses            16833    17761     +928
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b3344...2ef8b35. Read the comment docs.

mythrocks
mythrocks reviewed Nov 11, 2021
View reviewed changes
Copy link
Contributor
@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally 👍. Some minor nitpicks, plus a possible correction for handling sliced/offset input columns.

8000
revans2
revans2 requested changes Nov 11, 2021
View reviewed changes
mythrocks
mythrocks approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor
@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍, save for the javadoc updates.

@ttnghia ttnghia requested a review from revans2 November 11, 2021 15:42
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 11, 2021
@ttnghia ttnghia requested a review from davidwendt November 11, 2021 15:56
@ttnghia
Copy link
Contributor Author
ttnghia commented Nov 11, 2021

Rerun tests.

davidwendt
davidwendt approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor
@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for libcudf C++ changes.

@ttnghia
Copy link
Contributor Author
ttnghia commented Nov 11, 2021

Rerun tests.

3 similar comments
@ttnghia
Copy link
Contributor Author
ttnghia commented Nov 11, 2021

Rerun tests.

@ttnghia
Copy link
Contributor Author
ttnghia commented Nov 11, 2021

Rerun tests.

@ttnghia
Copy link
Contributor Author
ttnghia commented Nov 11, 2021

Rerun tests.

@ttnghia
Copy link
Contributor Author
ttnghia commented Nov 11, 2021

Rerun tests.

@ttnghia
Copy link
Contributor Author
ttnghia commented Nov 11, 2021

CI tests keep failing due to data corruption of the downloaded files.
Rerun tests.

@ttnghia
Copy link
Contributor Author
ttnghia commented Nov 11, 2021

Rerun tests.

2 similar comments
@ttnghia
Copy link
Contributor Author
ttnghia commented Nov 11, 2021

Rerun tests.

@ttnghia
Copy link
Contributor Author
ttnghia commented Nov 12, 2021

Rerun tests.

@ttnghia
Copy link
Contributor Author
ttnghia commented Nov 12, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 10cbbd7 into rapidsai:branch-21.12 Nov 12, 2021
@ttnghia ttnghia deleted the jni_drop_list_duplicates branch November 15, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

@mythrocks mythrocks mythrocks approved these changes

@davidwendt davidwendt davidwendt approved these changes

@andygrove andygrove Awaiting requested review from andygrove

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team feature request New feature or request Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ttnghia @revans2 @mythrocks @davidwendt
0