[BUG] Use raw strings to avoid SyntaxErrors in parsed docstrings. #9526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
approved these changes
Oct 26, 2021
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9526 +/- ##
================================================
- Coverage 10.79% 10.66% -0.13%
================================================
Files 116 117 +1
Lines 18869 19725 +856
================================================
+ Hits 2036 2104 +68
- Misses 16833 17621 +788
Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at running cuDF Python tests with
-Werrorbut ran into a few problems. One of those problems is that the docstrings instring.pyuse\din code examples for regular expressions, which causes a SyntaxError if the docstring is parsed during test collection because\dis not a valid escape sequence in Python. Using a raw string in those methods' docstrings fixes the problem.(Eventually I'd like to get our Python tests to fail if warnings are encountered -- with a list of excluded/filtered warnings that are outside our control.)