8000 Preserve the decimal scale when creating a default scalar by revans2 · Pull Request #9449 · rapidsai/cudf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Preserve the decimal scale when creating a default scalar #9449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2021
Merged

Preserve the decimal scale when creating a default scalar #9449

merged 2 commits into from
Oct 15, 2021

Conversation

revans2
Copy link
Contributor
@revans2 revans2 commented Oct 15, 2021

this fixes #9431

I am no C++ expert so I am happy to get any advice on a better way to fix this issue.

@revans2 revans2 added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Oct 15, 2021
@revans2 revans2 self-assigned this Oct 15, 2021
@revans2 revans2 requested a review from a team as a code owner October 15, 2021 13:59
davidwendt
davidwendt requested changes Oct 15, 2021
View reviewed changes
Copy link
Contributor
@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. There is an oddness with a type-dispatcher call within a type-checking switch statement. But that is unrelated to this change and can be fixed in a follow up PR.

rgsl888prabhu
rgsl888prabhu approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor
@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only things mentioned above needs to be addressed, rest looks good.

@codecov
Copy link
codecov bot commented Oct 15, 2021 •
edited
Loading

Codecov Report

Merging #9449 (543480a) into branch-21.12 (ab4bfaa) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9449      +/-   ##
================================================
- Coverage         10.79%   10.78%   -0.01%     
================================================
  Files               116      117       +1     
  Lines             18869    19445     +576     
================================================
+ Hits               2036     2097      +61     
- Misses            16833    17348     +515
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/strings/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 061aa3a...543480a. Read the comment docs.

8000
@revans2
Copy link
Contributor Author
revans2 commented Oct 15, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit baeffb8 into rapidsai:branch-21.12 Oct 15, 2021
@revans2 revans2 deleted the default_scalar_functor branch October 15, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@davidwendt davidwendt davidwendt approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@revans2 revans2

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] default_scalar_functor loses scale for decimal types
3 participants
@revans2 @rgsl888prabhu @davidwendt
0