Implement lists::stable_sort_lists for stable sorting of elements within each row of lists column
#9425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stable_segmented_sorted_order and stable_segmented_sort_by_keylists::stable_sort_lists for stable sorting of elements within each row of lists column
|
From looking at the tests, it looks like we only support stable-sorting of single-level lists. (i.e. nested types aren't supported.) Is that correct? |
mythrocks
reviewed
Oct 15, 2021
mythrocks
reviewed
Oct 15, 2021
codereport
approved these changes
Oct 18, 2021
|
Rerun tests. |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9425 +/- ##
================================================
+ Coverage 10.79% 10.83% +0.04%
================================================
Files 116 117 +1
Lines 18869 19442 +573
================================================
+ Hits 2036 2106 +70
- Misses 16833 17336 +503
Continue to review full report at Codecov.
|
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 11, 2021
…ns (#9345) This PR changes the interface of `lists::drop_list_duplicates` such that it may accept a second (optional) input `values` lists column, and returns a pairs of lists columns containing the results of copying the input column without duplicate entries. If the optional `values` column is given, the users are responsible to have the keys-values columns having the same number of entries in each row. Otherwise, the results will be undefined. When copying the key entries, the corresponding value entries are also copied at the same time. A parameter `duplicate_keep_option` reused from stream compaction is used to specify which duplicate keys will be copying. This closes #9124, and blocked by #9425. Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - Jake Hemstad (https://github.com/jrhemstad) - https://github.com/nvdbaranec URL: #9345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
lists::stable_sort_liststhat can sort elements within rows of lists column using stable sort. This is necessary for implementinglists::drop_list_duplicatesthat operates on keys-values columns input when we want to remove the values corresponding to duplicate keys withKEEP_FIRSTorKEEP_LASToption.In order to implement
lists::stable_sort_lists, stable sort versions for thesegmented_sorted_orderandsegmented_sort_by_keyhave also been implemented, which can maintain the order of equally-compared elements within segments.This PR blocks #9345.