8000 Fix the crash in stats code by devavret · Pull Request #9368 · rapidsai/cudf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix the crash in stats code #9368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2021
Merged

Fix the crash in stats code #9368

merged 1 commit into from
Oct 5, 2021

Conversation

devavret
Copy link
Contributor
@devavret devavret commented Oct 5, 2021

stat.(min/max)_value.str_val.length is used in calculating allocation size for page/stripe headers. Not zero initializing stat caused these values to be garbage.
Also re-enabled the pytest that was disabled in #9230

Fixes #9231

@devavret
Fix the crash in stats code
ebd7ae4 
stat.(min/max)_value.str_val.length is used in calculating allocation size for page/stripe headers. Not zero initializing stat caused these values to be garbage.
Also re-enable the pytest that was disabled in rapidsai#9230
@devavret devavret added bug Something isn't working 3 - Ready for Review Ready for review by team cuIO cuIO issue 4 - Needs cuIO Reviewer non-breaking Non-breaking change labels Oct 5, 2021
@devavret devavret requested review from a team as code owners October 5, 2021 00:07
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Oct 5, 2021
galipremsagar
galipremsagar approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor
@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@codecov
Copy link
codecov bot commented Oct 5, 2021 •
edited
Loading

Codecov Report

Merging #9368 (a13574a) into branch-21.12 (ab4bfaa) will decrease coverage by 0.02%.
The diff coverage is 1.76%.

❗ Current head a13574a differs from pull request most recent head ebd7ae4. Consider uploading reports for the commit ebd7ae4 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9368      +/-  
8000
 ##
================================================
- Coverage         10.79%   10.76%   -0.03%     
================================================
  Files               116      116              
  Lines             18869    19474     +605     
================================================
+ Hits               2036     2096      +60     
- Misses            16833    17378     +545
Impacted Files Coverage Δ
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/timedelta.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908c130...ebd7ae4. Read the comment docs.

@devavret
Copy link
Contributor Author
devavret commented Oct 5, 2021

rerun tests

@devavret devavret requested a review from kaatish October 5, 2021 12:44
@devavret
Copy link
Contributor Author
devavret commented Oct 5, 2021

Merging now despite the java CI failure because it seems unrelated and is also seen in 9320 and 9334

@devavret
Copy link
Contributor Author
devavret commented Oct 5, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fe04d21 into rapidsai:branch-21.12 Oct 5, 2021
@jrhemstad
Copy link
Contributor
jrhemstad commented Oct 5, 2021 •
edited
Loading

Consider in a future change making the default ctor of statistics_chunk default initialize it's members to avoid issues like this in the future.

@jlowe jlowe mentioned this pull request Oct 5, 2021
Closed
@devavret
Copy link
Contributor Author
devavret commented Oct 5, 2021

Consider in a future change making the default ctor of statistics_chunk default initialize it's members to avoid issues like this in the future.

Generally, many of the structs in cuIO are used as part of a shared state variable which requires that the members cannot be initialized.

@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuIO Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@elstehle elstehle elstehle approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@davidwendt davidwendt Awaiting requested review from davidwendt davidwendt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@kaatish kaatish Awaiting requested review from kaatish

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Parquet writer pytest intermittently fails CI
7 participants
@devavret @jrhemstad @hyperbolic2346 @elstehle @galipremsagar @brandon-b-miller @vyasr
0