8000 Switch ingress to extension api by StrongMonkey · Pull Request #526 · rancher/rio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Switch ingress to extension api #526

Merged
merged 2 commits into from
Sep 27, 2019
Merged

Switch ingress to extension api #526

merged 2 commits into from
Sep 27, 2019

Conversation

StrongMonkey
Copy link
Contributor

No description provided.

@StrongMonkey StrongMonkey changed the title Switch ingress to extension api WIP: Switch ingress to extension api Sep 27, 2019
@StrongMonkey
Copy link
Contributor Author

Need rancher/wrangler-api#7

@StrongMonkey
Copy link
Contributor Author

This is to fix #525.

@StrongMonkey StrongMonkey mentioned this pull request Sep 27, 2019
Closed
@ibuildthecloud
Copy link
Contributor

hellz no?

@ibuildthecloud
Copy link
Contributor

okay.... I'll accept it.

@StrongMonkey
Copy link
Contributor Author

@daxmc99 @cbron Can you review this pr? I just found out that ingress for networking api won't work well with kubernetes 1.13 or below.

From 1.14 changelogs https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.14.md

Ingress resources are now available via networking.k8s.io/v1beta1. Ingress resources in extensions/v1beta1 are deprecated and will no longer be served in v1.18. Existing persisted data is available via the new API group/version (#74057, @liggitt)

@StrongMonkey StrongMonkey changed the title WIP: Switch ingress to extension api Switch ingress to extension api Sep 27, 2019
cbron
cbron approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor
@cbron cbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
For reference today the following versions are available in EKS: 1.14.6, 1.13.10, 1.12.10, 1.11.10, and we can assume 1.18 is about 6 months away given current release schedule, so we should probably keep supporting for now but put a note somewhere about it being deprecated soon.

@StrongMonkey StrongMonkey merged commit 303f365 into rancher:master Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cbron cbron cbron approved these changes

@daxmc99 daxmc99 Awaiting requested review from daxmc99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StrongMonkey @ibuildthecloud @cbron
0