8000 Finalize constants, variables, and versions for v2.6.1 by nickgerace · Pull Request #34925 · rancher/rancher · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Finalize constants, variables, and versions for v2.6.1 #34925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2021
Merged

Finalize constants, variables, and versions for v2.6.1 #34925

merged 1 commit into from
Oct 8, 2021

Conversation

nickgerace
Copy link
Contributor

@nickgerace
Copy link
Contributor Author

Note to reviews: the UI tags have not changed yet.

@nickgerace nickgerace changed the title [DO NOT MERGE] Finalize v2.6.1 consts and update RKE module to v1.3.1 Finalize constants, variables, and versions for v2.6.1 Sep 30, 2021
@nickgerace nickgerace marked this pull request as ready for review September 30, 2021 16:17
luthermonson
luthermonson previously approved these changes Sep 30, 2021
View reviewed changes
@nickgerace
Copy link
Contributor Author

Note to reviewers:

  • Final CLI: v2.4.13
  • Final RKE: v1.3.1

@nickgerace nickgerace changed the title Finalize constants, variables, and versions for v2.6.1 [DO NOT MERGE] Finalize constants, variables, and versions for v2.6.1 Sep 30, 2021
@nickgerace nickgerace marked this pull request as draft September 30, 2021 19:33
@nickgerace nickgerace requested a review from cbron October 8, 2021 18:57
@nickgerace nickgerace changed the title [DO NOT MERGE] Finalize constants, variables, and versions for v2.6.1 Finalize constants, variables, and versions for v2.6.1 Oct 8, 2021
@nickgerace nickgerace marked this pull request as ready for review October 8, 2021 18:58
cbron
cbron previously approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor
@cbron cbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I don't see any rc's in go.mod. Might run go-generate again.

@nickgerace nickgerace dismissed stale reviews from cbron and luthermonson via f31ec22 October 8, 2021 21:36
@nickgerace nickgerace merged commit 9801a05 into rancher:release/v2.6 Oct 8, 2021
@nickgerace nickgerace deleted the release-v2.6-final branch October 8, 2021 22:51
@nickgerace nickgerace mentioned this pull request Oct 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbron cbron cbron approved these changes

@kinarashah kinarashah Awaiting requested review from kinarashah

@thedadams thedadams Awaiting requested review from thedadams

@snasovich snasovich Awaiting requested review from snasovich

@brendarearden brendarearden Awaiting requested review from brendarearden

@luthermonson luthermonson Awaiting requested review from luthermonson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickgerace @cbron @luthermonson
0