Make max concurrent reconciles configurable for agent and remaining controllers #3094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reconcilers for clusters, cluster groups and image scans now have configurable `controller-runtime` worker counts, similarly to what is already supported for gitrepo, bundle and bundle deployment reconcilers.
Fleet's cleanup logic does not make use of controller-runtime reconcilers, hence does not need environment variables specifying how many workers such reconcilers can use.
Reconcilers living in the Fleet agent now have configurable `controller-runtime` worker counts, similarly to what is already supported in the Fleet controller.
manno
approved these changes
Dec 9, 2024
weyfonk
added a commit
to weyfonk/fleet
that referenced
this pull request
Dec 19, 2024
…ontrollers (rancher#3094) * Make worker count configurable for cluster, clustergroup and imagescan Reconcilers for clusters, cluster groups and image scans now have configurable `controller-runtime` worker counts, similarly to what is already supported for gitrepo, bundle and bundle deployment reconcilers. * Remove workers env vars from cleanup container Fleet's cleanup logic does not make use of controller-runtime reconcilers, hence does not need environment variables specifying how many workers such reconcilers can use. * Make worker count configurable for agent reconcilers Reconcilers living in the Fleet agent now have configurable `controller-runtime` worker counts, similarly to what is already supported in the Fleet controller.
manno
pushed a commit
that referenced
this pull request
Dec 20, 2024
* Make max concurrent reconciles configurable for agent and remaining controllers (#3094) * Make worker count configurable for cluster, clustergroup and imagescan Reconcilers for clusters, cluster groups and image scans now have configurable `controller-runtime` worker counts, similarly to what is already supported for gitrepo, bundle and bundle deployment reconcilers. * Remove workers env vars from cleanup container Fleet's cleanup logic does not make use of controller-runtime reconcilers, hence does not need environment variables specifying how many workers such reconcilers can use. * Make worker count configurable for agent reconcilers Reconcilers living in the Fleet agent now have configurable `controller-runtime` worker counts, similarly to what is already supported in the Fleet controller. * Expose agent worker counts in fleet chart (#3152) This enables agent worker counts to be configured when installing the `fleet` chart, which is easier than tweaking individual releases of the `fleet-agent` chart. This still needs work to enable worker count updates through `helm upgrade --reuse-values` though, as this updates the `fleet-agent` `StatefulSet` _twice_, the second time with default values (50 workers per reconciler).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes max concurrent reconciles configurable, through worker counts, for reconcilers which had hard-coded counts in the Fleet controller (ie cluster, cluster group and imagescan reconcilers), and for reconcilers living in the agent.
The same default value (
50) is used everywhere, although different values could make more sense as defaults, eg. a lower value for the drfit reconciler.Refers to #2915.