8000 Fix some potential bugs and add a masked API key property by raman325 · Pull Request #25 · raman325/pytomorrowio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix some potential bugs and add a masked API key property #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 21, 2022
Merged

Fix some potential bugs and add a masked API key property #25

merged 4 commits into from
Sep 21, 2022

Conversation

raman325
Copy link
Owner
@raman325 raman325 commented Sep 21, 2022 •
edited
Loading

Potential bugs fixed:

  • force no compression when sending data since the server occasionally seems to respond with a 400 Can not decode content-encoding: gzip
  • Switch from json.dumps to using aiohttp's internal serialization logic
  • Remove filter for content-type check on response - we will handle a parsing exception anyway

Feature:

  • Add masked API key property. We want to mask the key in the coordinator name so logs can more easily be posted

lymanepp
lymanepp reviewed Sep 21, 2022
View reviewed changes
@codecov-commenter
Copy link

Codecov Report

Base: 85.18% // Head: 88.79% // Increases project coverage by +3.61% 🎉

Coverage data is based on head (feebbec) compared to base (267fc61).
Patch coverage: 91.34% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   85.18%   88.79%   +3.61%     
==========================================
  Files           7        7              
  Lines         324      357      +33     
==========================================
+ Hits          276      317      +41     
+ Misses         48       40       -8
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
pytomorrowio/pytomorrowio.py 89.94% <90.90%> (+6.51%) ⬆️
pytomorrowio/__init__.py 100.00% <100.00%> (ø)
pytomorrowio/const.py 92.17% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raman325 raman325 merged commit 2c88bf0 into master Sep 21, 2022
@raman325 raman325 deleted the api branch September 21, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lymanepp lymanepp lymanepp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raman325 @codecov-commenter @lymanepp
0