8000 Consider partial content HTTP status as successful by lymanepp · Pull Request #24 · raman325/pytomorrowio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Consider partial content HTTP status as successful #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

Consider partial content HTTP status as successful #24

merged 1 commit into from
Jul 20, 2022

Conversation

lymanepp
Copy link
Collaborator

This resolves home-assistant/core#75465 locally for me.

@lymanepp lymanepp requested a review from raman325 July 19, 2022 22:14
@lymanepp lymanepp mentioned this pull request Jul 19, 2022
Closed
@codecov-commenter
Copy link

Codecov Report

Merging #24 (9ce2743) into master (267fc61) will increase coverage by 3.51%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   85.18%   88.70%   +3.51%     
==========================================
  Files           7        7              
  Lines         324      354      +30     
==========================================
+ Hits          276      314      +38     
+ Misses         48       40       -8
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
pytomorrowio/pytomorrowio.py 89.79% <91.20%> (+6.36%) ⬆️
pytomorrowio/__init__.py 100.00% <100.00%> (ø)
pytomorrowio/const.py 92.17% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8407d8...9ce2743. Read the comment docs.

@lymanepp
Copy link
Collaborator Author

I sent a tomorrow.io support request with the following message

It looks like the V4 API started returning status code 206 today which is a breaking change for our application. We can obviously change our application to handle that, but I don't see any documentation regarding this change. It would be great if we could register to receive notification of API changes before they happen to avoid breaking our application in the real world.

@raman325 raman325 merged commit 6447b6c into raman325:master Jul 20, 2022
@lymanepp lymanepp deleted the http-partial-content branch July 20, 2022 01:52
@apetryk2 apetryk2 mentioned this pull request Jul 20, 2022
Closed
@GSzabados
Copy link

I just bumped manually pytomorrowio to 0.3.4 and it does not solve the issue.

2022-07-20 15:40:53 INFO (SyncWorker_2) [homeassistant.util.package] Attempting install of pytomorrowio==0.3.4
2022-07-20 15:41:16 INFO (MainThread) [homeassistant.setup] Setting up tomorrowio
2022-07-20 15:41:16 INFO (MainThread) [homeassistant.setup] Setup of domain tomorrowio took 0.0 seconds
2022-07-20 15:41:21 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 4.775 seconds (success: False)
2022-07-20 15:41:21 WARNING (MainThread) [homeassistant.config_entries] Config entry 'Tomorrow.io - Home' for tomorrowio integration not ready yet; Retrying in background
2022-07-20 15:42:38 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 16.358 seconds (success: False)

@GSzabados
Copy link

Restarted HA again with 0.3.4 already installed and it started to work after 5 minutes. My guess that something has changed again on the API side:


2022-07-20 15:55:30 INFO (MainThread) [homeassistant.setup] Setting up tomorrowio
2022-07-20 15:55:30 INFO (MainThread) [homeassistant.setup] Setup of domain tomorrowio took 0.0 seconds
2022-07-20 15:55:50 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 18.572 seconds (success: False)
2022-07-20 15:55:50 WARNING (MainThread) [homeassistant.config_entries] Config entry 'Tomorrow.io - Home' for tomorrowio integration not ready yet; Retrying in background
2022-07-20 15:57:22 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 4.025 seconds (success: False)
2022-07-20 15:57:42 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 4.420 seconds (success: False)
2022-07-20 15:58:16 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 1.282 seconds (success: False)
2022-07-20 15:58:57 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 0.634 seconds (success: False)
2022-07-20 16:00:18 DEBUG (MainThread) [homeassistant.components.tomorrowio] Finished fetching Tomorrow.io - Home data in 0.702 seconds (success: True)
2022-07-20 16:00:18 INFO (MainThread) [homeassistant.components.sensor] Setting up sensor.tomorrowio
2022-07-20 16:00:18 INFO (MainThread) [homeassistant.components.weather] Setting up weather.tomorrowio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raman325 raman325 raman325 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tomorrow.io will not start
4 participants
@lymanepp @codecov-commenter @GSzabados @raman325
0