API cleanup #2
API cleanup #2
Conversation
API cleanup
|
Hi @raman325, hopefully you don't mind getting a PR like this... My primary focus was finishing/fixing the type annotations. Along the way I refactored some duplicated code. I tried to avoid gratuitous changes. I wasn't able to grok the field filtering logic so I simplified it and back-checked it against the previous results for each valid timestep. |
| @@ -1,4 +1,4 @@ | |||
| pip==19.2.3 | |||
| pip>=21.0,<22.1 | |||
There was a problem hiding this comment.
|
thanks for this PR. Totally open for changes and updates, and I will happily acknowledge that this library isn't very well architected, I just sought out to solve the problem. Given the number of changes it will take me a bit to review but at first glance this is a great improvement, thanks! |
|
I added one unit test as a starting point. |
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=========================================
Coverage ? 71.16%
=========================================
Files ? 7
Lines ? 274
Branches ? 0
=========================================
Hits ? 195
Misses ? 79
Partials ? 0 Continue to review full report at Codecov.
|
|
let me know when you feel like you are done with your changes, and a sincere thank you for this PR, it will be a huge help going forward! |
| type=TYPE_PRECIPITATION, | ||
| ), | ||
| "hailBinary": FieldDefinition( | ||
| max_timestep=REALT 8000 IME, |
There was a problem hiding this comment.
This was previously 30 mins, but API response indicates that it's only available for realtime.
There are still a few tests that need to be written, but I'm going to call it done for now. Let me know if you find anything that needs to be resolved. I have a request--if/when you merge my changes, please combine my 99 commits into a single one. |
Fix type annotations
Fix linting suggestions
API cleanup