8000 Revert breaking change for HA integration by lymanepp · Pull Request #11 · raman325/pytomorrowio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert breaking change for HA integration #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2022
Merged

Revert breaking change for HA integration #11

merged 1 commit into from
Apr 19, 2022

Conversation

lymanepp
Copy link
Collaborator

@raman325, while reviewing the HA integration today, I realized that I had previously introduced a breaking change soft of related to your MAX_FIELDS changes. Sorry about that.

Note that requesting Min, Max and Avg for hourly or smaller timesteps doesn't make a lot of sense since they will all have the same values. But that's necessary since a single call is being made to retrieve all forecast data. And it will probably cause MAX_FIELDS to be exceeded.

@raman325
Copy link
Owner

I don't think this actually breaks the integration because we aren't using _forecast in the update method, we are calling the API directly in realtime_and_all_forecasts. With that being said I think this can be cleaned up so that we aren't duplicating logic.

@raman325 raman325 merged commit f911002 into raman325:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raman325 raman325 raman325 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lymanepp @raman325
0