8000 fix regressions in create wallet and import wallet flows by natew · Pull Request #6709 · rainbow-me/rainbow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix regressions in create wallet and import wallet flows #6709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 53 commits into
base: develop
Choose a base branch
from
Open

fix regressions in create wallet and import wallet flows #6709

wants to merge 53 commits into from
+254 −218

Conversation

natew
Copy link
Contributor
@natew natew commented Jun 25, 2025 •
edited
Loading

Fixes APP-2793
Fixes APP-2792
Fixes APP-2791

What changed (plus any additional context for devs)

We were aggressively skipping loadWallets so most of the fixes just come from bringing that back, I tried to clean up a couple things which is causing this unfortunate diff.

  • Improves loadWallets logic and performance
  • Fixes the copy/paste backup flow dev helper to not crash
  • Improves useWalletsWithBalancesAndNames to avoid hooks / performance
  • Fixes race condition by not awaiting setSelectedWallet before calling initializeWallet
  • Starts a refresh of wallet info right after backup (ensures data is fetched faster on load)
  • Adds retry logic to fetching ENS avatars to recover from failures
  • Moves logic that caused race condition issues by calling setSelected + update back to back into a single flow
  • Refactor loadWallets and document why its needed to call again
  • Improve loadWallet perf by doing a Promise.all
  • Improve createAccount with a single setSelectedWallet instead of lots of disparate calls
  • Improve logic to cache ENS fetching

What to test

Wallet flows fully.

@linear Linear
Copy link
linear bot commented Jun 25, 2025

APP-2793 ENS names are not resolved on both import and restore

APP-2792 Creating a new wallet group doesn't create wallet until killing app and relaunching

APP-2791 Restoring a backup shows as not backed up

christianbaroni
christianbaroni reviewed Jun 25, 2025
View reviewed changes
@natew natew requested a review from christianbaroni June 25, 2025 19:14
@jinchung
Copy link
Member

Launch in simulator or device for 5729d5a

@jinchung
Copy link
Member

Launch in simulator or device for de44e15

@natew natew requested review from maxbbb and BrodyHughes June 26, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianbaroni christianbaroni Awaiting requested review from christianbaroni

@maxbbb maxbbb Awaiting requested review from maxbbb

@BrodyHughes BrodyHughes Awaiting requested review from BrodyHughes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natew @jinchung @christianbaroni
0