Add wrap test and go through settings flows #6700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrodyHughes
commented
Jun 24, 2025
| @@ -8,7 +8,7 @@ env: | |||
| visible: | |||
| id: welcome-screen | |||
| # the test fail quite often if the timeout is too low | |||
| timeout: 30000 | |||
| timeout: 60000 | |||
There was a problem hiding this comment.
noticed some timeout issues with 30 occasionally on startup
BrodyHughes
commented
Jun 24, 2025
| @@ -203,12 +203,18 @@ export function useAnimatedSwapStyles({ | |||
| SPRING_CONFIGS.springConfig | |||
| ), | |||
| borderRadius: withSpring(isBottomSheetOpen ? 40 : 0, SPRING_CONFIGS.springConfig), | |||
| bottom: withSpring(isBottomSheetOpen ? Math.max(safeAreaInsetValues.bottom, 28) : -2, SPRING_CONFIGS.springConfig), | |||
| bottom: IS_TEST | |||
There was a problem hiding this comment.
a lot of this conditional styling for IS_TEST is necessary for maestro to see elements
| @@ -45,6 +46,9 @@ export default function RainbowContextWrapper({ children }: PropsWithChildren) { | |||
| const [globalState, updateGlobalState] = useState({}); | |||
|
|
|||
| useEffect(() => { | |||
| if (IS_TEST) { | |||
There was a problem hiding this comment.
this adds WETH to the favorites list, which allows us to swap into it
| backgroundColor="accent" | ||
| style={{ maxWidth: 175 }} | ||
| > | ||
| <Box as={ButtonPressAnimation} paddingVertical="8px" marginVertical="-8px" style={{ maxWidth: 175 }}> |
There was a problem hiding this comment.
removed background color here. I think this was a bug. caused the gas options to have a blue squared background on Android.
de6b9cf to
49edc55
Compare
|
Note for reviewers: Unit test failure is unrelated and @natew is handing in a separate PR. |
EQuimper
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds one flow and several test case assertions.
Added:
I decided to split these tests through the two swaps flows we currently have so that no one is super long and maybe to also reduce flakiness if possible.