atomic swaps [APP-2658] #6695
Open
atomic swaps [APP-2658] #6695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derHowie
commented
Jun 17, 2025
| return shouldDelegate; | ||
| }; | ||
|
|
||
| export const getApproveAndSwapCalls = async (quote: Quote | CrosschainQuote) => { |
There was a problem hiding this comment.
is it okay to loadWallet here? @jinchung
derHowie
commented
Jun 17, 2025
| return delegateCalldata; | ||
| }; | ||
|
|
||
| export const simulateDelegatedTransaction = async (quote: Quote | CrosschainQuote) => { |
There was a problem hiding this comment.
Loading wallet above makes simulation / gas estimation easier to pass around
be9885d to
cb6aba8
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce viem options for provider and wallet:
loadWalletViem+getProviderViem.Incorporates the rainbow delegation package for transaction execution and for building gas estimation logic.
Will perform atomic batches of approve and swap when the experiment is switched on.
What to test:
Ensure that with the flag off, all swaps, whether they require an approval, perform as usual.
With the flag on, verify whether atomic batches of approve and swap are being executed.
Ensure with the flag on, swaps that do not require an approval still behave as normal.