8000 Fix token over fetching on position card by maxbbb · Pull Request #6688 · rainbow-me/rainbow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix token over fetching on position card #6688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

maxbbb
Copy link
Contributor
@maxbbb maxbbb commented Jun 13, 2025

What changed (plus any additional context for devs)

  • Previously the CoinIconForStack component was fetching the entire token object to get an image url that was already in the list data, resulting in many unnecessary fetches on wallet mount.

Screen recordings / screenshots

What to test

@jinchung
Copy link
8000
Member

Launch in simulator or device for b43f88b

@maxbbb maxbbb requested a review from walmat June 17, 2025 14:30
Copy link
Contributor
@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice optimization

@maxbbb maxbbb merged commit e166570 into develop Jun 17, 2025
7 of 8 checks passed
@maxbbb maxbbb deleted the @kane/fix-coin-icon-fetching branch June 17, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0