8000 Fix yarn android launching the activity by janicduplessis · Pull Request #6678 · rainbow-me/rainbow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix yarn android launching the activity #6678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

janicduplessis
Copy link
Contributor

Fixes APP-####

What changed (plus any additional context for devs)

This was changed because of rn-fetch-blob, but it is actually only needed if using Android Download Manager, which we don't (useDownloadManager config).

image

Screen recordings / screenshots

Before:

image

After:

image

What to test

  • yarn android -> Check that app is now launched
  • Test that saving NFTs still works

@janicduplessis janicduplessis merged commit 495900c into develop Jun 12, 2025
7 of 8 checks passed
@janicduplessis janicduplessis deleted the @janic/fix-android-launch-activity branch June 12, 2025 15:52
ibrahimtaveras00 added a commit that referenced this pull request Jun 18, 2025
ibrahimtaveras00 added a commit that referenced this pull request Jun 18, 2025
ibrahimtaveras00 added a commit that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0