8000 Fix saving SVG NFTs by janicduplessis · Pull Request #6677 · rainbow-me/rainbow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix saving SVG NFTs #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Fix saving SVG NFTs #6677

merged 1 commit into from
Jun 12, 2025

Conversation

janicduplessis
Copy link
Contributor

Fixes APP-####

What changed (plus any additional context for devs)

While testing another PR I noticed a bug with downloading SVG NFTs. The code assumes the images are PNGs, but it is not always the case. Adding this option will convert the image to PNG if it is not already.

Screen recordings / screenshots

Screen.Recording.2025-06-11.at.4.07.53.PM.mov

What to test

  • Go to an SVG NFT (rainbowtestwallet.eth -> Arun Cattybinky is one)
  • Click ... and Save to Photos

Copy link
Member
@BrodyHughes BrodyHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tested on pixel 6.

@janicduplessis janicduplessis merged commit 9ed9d45 into develop Jun 12, 2025
7 of 9 checks passed
@janicduplessis janicduplessis deleted the @janic/fix-download-nft-svg branch June 12, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0