8000 fix layout for swaps gas menu / remove the priority fee for L2s that don't use it by BrodyHughes · Pull Request #6667 · rainbow-me/rainbow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix layout for swaps gas menu / remove the priority fee for L2s that don't use it #6667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 11, 2025
Merged

fix layout for swaps gas menu / remove the priority fee for L2s that don't use it #6667

merged 5 commits into from
Jun 11, 2025

Conversation

BrodyHughes
Copy link
Member
@BrodyHughes BrodyHughes commented Jun 6, 2025 •
edited
Loading

Fixes APP-2679

What changed (plus any additional context for devs)

  • there were some small discrepancies between the send and swaps gas menus
  • this PR looks to bring them in sync and fix a few layout issues

Swaps gas panel changes:

Send gas panel changes:

Screen recordings / screenshots

UI Before UI After
Screenshot 2025-06-05 at 3 10 48 PM Screenshot 2025-06-05 at 10 22 49 PM
Screenshot 2025-06-05 at 3 11 35 PM Screenshot 2025-06-05 at 10 23 05 PM
Screenshot 2025-06-05 at 11 07 57 PM Screenshot 2025-06-05 at 11 15 57 PM

What to test

  • Does gas panel functionality work the same as production?
  • Are the visual elements better?
  • Are we displaying the correct gas items for the chains that care about those items?

@linear Linear
Copy link
linear bot commented Jun 6, 2025

APP-2679 Custom gas menu for L2 swaps is limited compared to the send menu options

@BrodyHughes BrodyHughes requested review from walmat and maxbbb June 6, 2025 15:47
walmat
walmat requested changes Jun 9, 2025
View reviewed changes
@BrodyHughes BrodyHughes requested a review from walmat June 9, 2025 19:17
maxbbb
maxbbb approved these changes Jun 10, 2025
View reviewed changes
BrodyHughes and others added 2 commits June 11, 2025 11:12
@BrodyHughes @maxbbb
Update src/__swaps__/screens/Swap/components/GasPanel.tsx
831755e 
Co-authored-by: Kane Thomas <kanethomas1997@gmail.com>
@BrodyHughes
kane changes
7b16800
@BrodyHughes BrodyHughes merged commit 47d19bb into develop Jun 11, 2025
7 of 9 checks passed
@BrodyHughes BrodyHughes deleted the brody/app-2679-custom-gas-menu-for-l2-swaps-is-limited-compared-to-the-send branch June 11, 2025 17:02
@sentry-io Sentry.io
Copy link
sentry-io bot commented Jun 16, 2025 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: [handleDeeplink]: invalid or unknown deeplink sentryTransport(index.android) View Issue
  • ‼️ Error: [handleDeeplink]: invalid address or ENS provided sentryTransport(index.android) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat approved these changes

@maxbbb maxbbb maxbbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrodyHughes @walmat @maxbbb
0