Fix e2e ios tests #6613
Merged
Fix e2e ios tests #6613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0766451 to
8ee74e3
Compare
janicduplessis
commented
May 8, 2025
|
|
||
| echo "Waiting 5 seconds for Anvil to start..." | ||
|
|
||
| # Start Anvil in the background (show logs in terminal + save to file) |
There was a problem hiding this comment.
I moved starting anvil when running all tests here, instead of in the ci script to make it easier to run locally.
95877c9 to
cca779c
Compare
5bf1e94 to
f7723e1
Compare
BrodyHughes
approved these changes
May 9, 2025
| @@ -40,6 +40,26 @@ It is recommended that those commands are extracted to a flow for reuse. See `e2 | |||
|
|
|||
| ### Troubleshooting | |||
|
|
|||
| #### Cannot find view with a testID on iOS | |||
|
|
|||
| On iOS `testID` is implemented using `accessibilityIdentifier`. If a parent view is marked as `accessible=true` then it is considered a leaf node and its children `accessibilityIdentifier` won't be visible. Try moving the `testID` up to the accessible view or making the view not accessible if it makes sense in that case. Note that `ButtonPressAnimation` defaults to `accessible=true`. | |||
There was a problem hiding this comment.
this is really nice to document, ty.
walmat
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
This fixes the exit code of the iOS e2e script so it fails the github action properly. This also makes some adjustments to the tests so they pass on iOS.
Screen recordings / screenshots
What to test
Tests pass