Fix: LP Fees shown currency amount #6605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
commented
Apr 30, 2025
walmat
commented
May 2, 2025
src/analytics/event.ts
Outdated
There was a problem hiding this comment.
FYI will need to reconstruct charts with assets instead of asset
| const estimatedHorizontalPadding = 250; | ||
| const maxChars = Math.floor((DEVICE_WIDTH - estimatedHorizontalPadding) / avgCharWidth); | ||
|
|
||
| const NativeCurrencyDisplay = memo(function NativeCurrencyDisplay({ assets }: { assets: ClaimableType['assets'] }) { |
There was a problem hiding this comment.
this could use some more testing. Seemed good from my limited testing, but might be brittle with super long token names
Comment on lines
+57
to
+62
| export interface ClaimableAsset<T, A> { | ||
| asset: T; | ||
| amount: A; | ||
| usd_value: number; | ||
| value: string; | ||
| } |
There was a problem hiding this comment.
different asset types and amount can be formatted or a raw string depending on where we are in the flow.
maxbbb
requested changes
May 5, 2025
derHowie
approved these changes
May 5, 2025
Comment on lines
+34
to
+35
| backgroundColor={`rgba(41,90,247,1)`} | ||
| disabledBackgroundColor={`rgba(41,90,247,0.2)`} |
There was a problem hiding this comment.
Is this worth popping into DS or is it definitely a 1-off?
| const { nativeCurrency } = useAccountSettings(); | ||
| const { isDarkMode } = useColorMode(); | ||
|
|
||
| const color = !isDarkMode ? '#09111F' : globalColors.white100; |
There was a problem hiding this comment.
i'll ask in standup, not sure tbh
maxbbb
approved these changes
May 5, 2025
BrodyHughes
pushed a commit
that referenced
this pull request
May 9, 2025
* enable multi token LP claims * wrap up +N token logic and final tweaks * Update src/components/asset-list/RecyclerAssetList2/Claimable.tsx * bump claimables store v * fix up eth rewards types * remove unused nativeDisplay * remove useMemo for total value * finish merkl claimable title / subtile work * fix lint and code review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2606
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test
all claimable types and entry points