8000 Fix airdrop recipient input logic by maxbbb · Pull Request #6599 · rainbow-me/rainbow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix airdrop recipient input logic #6599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

Fix airdrop recipient input logic #6599

merged 2 commits into from
Apr 30, 2025

Conversation

maxbbb
Copy link
Contributor
@maxbbb maxbbb commented Apr 28, 2025

Fixes APP-2592, APP-2598

What changed (plus any additional context for devs)

  • The airdrop input logic had an incorrect assumption about skipping ENS resolution when pasting an ENS. This would allow you to continue to the review screen with raw ENS names rather than the resolved address.

Screen recordings / screenshots

RPReplay_Final1745876279.MP4

What to test

  • Paste and type some regular addresses as well as ENS names in the airdrop section. If QA could actually launch a coin with variations of typing and pasting that would be helpful.

@linear Linear
Copy link
linear bot commented Apr 28, 2025

APP-2592 [TokenLauncher] "invalid airdrop address: dfern.eth" for ENS names

APP-2598 Adding a basename to airdrop list in Token Launcher causes app to crash

@brunobar79
Copy link
Contributor

Launch in simulator or device for 833ebaa

@maxbbb maxbbb requested a review from derHowie April 29, 2025 13:49
derHowie
derHowie approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member
@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@brunobar79
Copy link
Contributor

Launch in simulator or device for 2888d1d

@maxbbb maxbbb merged commit 8d39532 into develop Apr 30, 2025
8 of 9 checks passed
@maxbbb maxbbb deleted the @kane/fix-launcher-pasting branch April 30, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat approved these changes

@derHowie derHowie derHowie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxbbb @brunobar79 @walmat @derHowie
0