8000 Increase NFT Cache Duration [APP-2583] by derHowie · Pull Request #6586 · rainbow-me/rainbow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Increase NFT Cache Duration [APP-2583] #6586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Conversation

derHowie
Copy link
Member

What changed (plus any additional context for devs)

Increased internal NFT cache duration.

Screen recordings / screenshots

n/a

What to test

Nothing, however any input on whether this change could have unintended consequences would be helpful.

Copy link
linear bot commented Apr 22, 2025

@derHowie derHowie requested a review from walmat April 22, 2025 18:29
Copy link
Contributor
@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will have any technically negative consequences, however would it be nice to notify users that we're transitioning nft data providers so in case they see stale data that's why?

@brunobar79
Copy link
Contributor

Launch in simulator or device for e4bf58f

@derHowie derHowie requested a review from maxbbb April 22, 2025 19:57
@derHowie derHowie merged commit 5870ecb into develop Apr 23, 2025
7 of 8 checks passed
@derHowie derHowie deleted the @chris/infinite-nfts branch April 23, 2025 14:53
ibrahimtaveras00 pushed a commit that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0