Fix walletconnect error sheet overflow #6577
Merged
+57
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derHowie
approved these changes
Apr 17, 2025
maxbbb
reviewed
Apr 21, 2025
maxbbb
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1913
What changed (plus any additional context for devs)
Fixes up the Portal screen to no longer use SlackSheet and instead opt to use a a fullscreen cool modal with desired sheet height. the body of the portal will overflow a scrollview if needed.
Screen recordings / screenshots
BEFORE
AFTER
What to test
no tests really needed for this.