Swaps fixes #6573
Merged
Swaps fixes #6573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haven't ever seen this happen, just in case due to the current lack of proper navigation typing
… network selector handling
…fter account switches
ibrahimtaveras00
approved these changes
Apr 17, 2025
maxbbb
approved these changes
Apr 17, 2025
derHowie
approved these changes
Apr 18, 2025
derHowie
pushed a commit
that referenced
this pull request
Apr 23, 2025
* Rework `navigateToSwaps` * Swaps bug fixes, performance improvements * Clean up remote config, fix slippage types * Clean up `AnimatedSpinner` image on unmount * Push missing files, lint fixes * Lint * Separate chain badge improvements * Separate user assets store type fixes, clean up error supression * Ensure `getSwapsNavigationParams` always returns valid params Haven't ever seen this happen, just in case due to the current lack of proper navigation typing * Fix swaps network selection input handling * Prevent swaps inputs from clearing unless `Cancel` is pressed, rework network selector handling * Prevent swap input re-render * Limit erratic gas state updates, propagate balance updates in swaps after account switches * Allow user assets to refresh while swaps is open * Remove unnecessary `useCleanupOnUnmount` component wrapper * Fix remaining `hasEnoughFundsForGas` / `maxSwappableAmount` edge cases * Reduce size of `FlipButton` hit box * Handle negative `decimalPlaces` in `scaleUpWorklet`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2566
Fixes APP-2508
Fixes APP-2368
Fixes APP-2568
What changed (plus any additional context for devs)
quote.value.swap-providerre-render triggered byuseAccountSettingswhen switching accounts. Now usingcurrencyfromuserAssetsStoreManagerto avoid these re-renders.navigateToSwapshelper, which removes all the redundant boilerplate from each swaps entry pointnavigateToSwapsare now applied directly — additional changes stemming from theinputValuesanimated reaction no longer occur on mounttrackQuickBuyMetadatabooleanswap-providerand fixes raps gas typestrackSwapEventhelper, and removes all JS thread shared value readsmaxSwappableAmountsetAssetto avoid shared value JS thread reads and JS/UI thread logic redundancysetAssetinstead of waiting for an animated reaction to triggerupdateInputValuesAfterFliplogic to be clearer and more predictableuseSwapInputsControlleranimated reactions to limit redundant logic and remove unnecessary workuseAnimatedReactioninstead ofuseDerivedValue) to prevent erratic updatesSwapNumberPadwhere fetches were being triggered for certain edits to the input value that didn't result in the number actually changing (e.g. adding/removing a decimal point, adding/removing zeros to the end of a number containing a decimal point)No Balancestate to the slider which snaps the slider back to zero if there's no input balanceScreen recordings / screenshots
What to test