8000 Ftl links fixes by maxbbb · Pull Request #6511 · rainbow-me/rainbow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ftl links fixes #6511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 20, 2025
Merged

Ftl links fixes #6511

merged 5 commits into from
Mar 20, 2025

Conversation

maxbbb
Copy link
Contributor
@maxbbb maxbbb commented Mar 19, 2025 •
edited
Loading

Fixes APP-2492, APP-2493

What changed (plus any additional context for devs)

  • Add support for showing Farcaster (Warpcast) and Other type links in about section of expanded state
  • Show buy section at top when asset is unowned.
  • Fix ftl input validators for twitter & farcaster allowing string to start with "@"

Screen recordings / screenshots

Simulator Screenshot - iPhone 15 Pro - 2025-03-19 at 22 25 07

@linear Linear
Copy link
linear bot commented Mar 19, 2025

APP-2493 Expanded sheet does not currently show Farcaster and Other link types in about section

APP-2492 Show buy buttons first above market data when loading token expanded state for non-owned tokens

@maxbbb maxbbb marked this pull request as ready for review March 20, 2025 02:27
@maxbbb maxbbb changed the title Minor asset expanded state cleanup Ftl links fixes Mar 20, 2025
jinchung
jinchung approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member
@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@christianbaroni christianbaroni self-requested a review March 20, 2025 05:26
@jinchung jinchung merged commit 3705fc1 into develop Mar 20, 2025
10 of 12 checks passed
@jinchung jinchung deleted the @kane/new-links branch March 20, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchung jinchung jinchung approved these changes

@christianbaroni christianbaroni christianbaroni approved these changes

@derHowie derHowie Awaiting requested review from derHowie

@ibrahimtaveras00 ibrahimtaveras00 Awaiting requested review from ibrahimtaveras00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxbbb @jinchung @christianbaroni
0