8000 Resolve dotenv xcconfig conflict by jinchung · Pull Request #6477 · rainbow-me/rainbow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Resolve dotenv xcconfig conflict #6477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2025
Merged

Resolve dotenv xcconfig conflict #6477

merged 2 commits into from
Mar 6, 2025

Conversation

jinchung
Copy link
Member
@jinchung jinchung commented Mar 4, 2025

What changed (plus any additional context for devs)

  • Resolves the conflict happening with react-native-dotenvs and xcconfigs.
  • Reverts previous changes in order to remove hardcoded urls.

After this PR gets merged, we can remove some of the overrides in the CI workflow.

Screen recordings / screenshots

  • Confirmed that "env var analysis" shows metadata URL correctly and in full
  • Confirmed token widget behaves as expected

What to test

  • Open "env var analysis" in internal dev settings and confirm metadata URL
  • Install token widget and that it behaves as expected

@jinchung jinchung requested a review from brunobar79 March 4, 2025 23:59
@jinchung jinchung changed the title @jin/dotenv xcconfig Resolve dotenv xcconfig conflict Mar 4, 2025
@jinchung jinchung marked this pull request as ready for review March 5, 2025 08:12
@brunobar79
Copy link
Contributor

Launch in simulator or device for 7a44321

@jinchung jinchung merged commit 283455a into develop Mar 6, 2025
10 of 12 checks passed
@jinchung jinchung deleted the @jin/dotenv-xcconfig branch March 6, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobar79 brunobar79 brunobar79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinchung @brunobar79
0