8000 Fix broken 'open in Rainbow' option in Safari share menu by walmat · Pull Request #6473 · rainbow-me/rainbow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix broken 'open in Rainbow' option in Safari share menu #6473

New issu 8000 e

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

Fix broken 'open in Rainbow' option in Safari share menu #6473

merged 1 commit into from
Feb 28, 2025

Conversation

walmat
Copy link
Contributor
@walmat walmat commented Feb 28, 2025

Fixes APP-2353

What changed (plus any additional context for devs)

BUG IN CLIENT OF UIKIT: The caller of UIApplication.openURL(:) needs to migrate to the non-deprecated UIApplication.open(:options:completionHandler:). Force returning false (NO).

Apple released a breaking change in iOS 18 that broke the method I was using to open the UIResponder. This uses the new application.open API on iOS 18 and the old logic for older iOS versions for both the Share and Open extensions.

Screen recordings / screenshots

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-28.at.15.32.14.mp4

What to test

does it work for you?

@linear Linear
Copy link
linear bot commented Feb 28, 2025

APP-2353 Fix broken 'open in Rainbow' option in Safari share menu

ibrahimtaveras00
ibrahimtaveras00 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor
@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked on my iPhone 12, QA Passed 👍🏽

@brunobar79
Copy link
Contributor

Launch in simulator or device for 5730cf6

@brunobar79 brunobar79 added the release for release blockers and release candidate branches label Feb 28, 2025
@walmat walmat merged commit 110c950 into develop Feb 28, 2025
7 of 8 checks passed
@walmat walmat deleted the @matthew/APP-2353 branch February 28, 2025 22:04
BrodyHughes pushed a commit that referenced this pull request Mar 3, 2025
@walmat @BrodyHughes
fix share menu broken on iOS 18 (#6473)
64158ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobar79 brunobar79 brunobar79 approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@derHowie derHowie Awaiting requested review from derHowie

@maxbbb maxbbb Awaiting requested review from maxbbb

Assignees
No one assigned
Labels
release for release blockers and release candidate branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walmat @brunobar79 @ibrahimtaveras00
0