Fix group name in connectors test #2399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the groupName literal in a test to match the expected connector output.
- Fixes a stray prefix in the
groupNametest data. - Ensures the test passes without a “Connect Timeout Error.”
Comments suppressed due to low confidence (1)
packages/rainbowkit/src/wallets/connectorsForWallets.test.ts:63
- The test data previously included the literal
groupName: "Test Group 1", which did not match the expected output and led to failures. Updating it to just'Test Group 1'aligns the fixture with the connector’s actual behavior.
[{ groupName: 'Test Group 1', wallets: [customWallet] }],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
groupNamestring inconnectorsForWallets.test.tsTesting
pnpm test(fails: Connect Timeout Error)PR-Codex overview
This PR focuses on correcting the
groupNameformat in theconnectorsForWalletsfunction call within the test file.Detailed summary
groupNamefrom'groupName: "Test Group 1"'to'Test Group 1'in the test case forconnectorsForWallets.