Fixed failing tests and IM deprecated warnings #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doing some simple composites are taking 30x longer with this 'fix'. |
|
Hi @drewwells, These changes should be separated into multiple commits. Please, try to make commits as independent as possible when sending PRs. Also, the changes you've made to IM would break several things, since GetVirtualPixels is not thread safe and it's not present in the IM version found in most distributions right now. Could you please clarify how the tests are failing with libgif 4.1.6? Thanks! |
|
Closing this for now, I'm still getting deprecated warnings about the current non-thread safe calls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resize has changed the name of Lanczos2lut to Lanczos2
I looked up the IM documentation to fix the deprecation warnings.
libgif tests are failing for libgif 4.1.6 from brew