8000 Do not overwrite OPENMS_DATA_PATH in PyOpenMS if it is already set by radusuciu · Pull Request #1 · radusuciu/OpenMS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not overwrite OPENMS_DATA_PATH in PyOpenMS if it is already set #1

New issue

Have a question 8000 about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2021
Merged

Do not overwrite OPENMS_DATA_PATH in PyOpenMS if it is already set #1

merged 3 commits into from
Sep 27, 2021

Conversation

radusuciu
Copy link
Owner

Description

I've got a lot of customizations (mostly to unimod.xml ) that I've set in a new directory that is references by OPENMS_DATA_PATH but pyopenms clobbers that on initialization. This simple modification should prevent it from doing so, if there is a path already set.

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@radusuciu radusuciu closed this Sep 27, 2021
@radusuciu radusuciu reopened this Sep 27, 2021
@radusuciu radusuciu merged commit dfe1f8b into develop Sep 27, 2021
radusuciu pushed a commit that referenced this pull request Apr 7, 2022
@emilpaulitz
Merge pull request #1 from OpenMS/develop
cef0e0c 
updating my fork
radusuciu pushed a commit that referenced this pull request Apr 7, 2022
@dhanmoni
Merge pull request #1 from jpfeuffer/gui/proteintable
232f491 
Some cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@radusuciu
0