8000 [3-0-stable] Handle more Ruby 3.5 incompatibilies by Earlopain · Pull Request #2337 · rack/rack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[3-0-stable] Handle more Ruby 3.5 incompatibilies #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 3-0-stable
Choose a base branch
from
Open

[3-0-stable] Handle more Ruby 3.5 incompatibilies #2337

wants to merge 1 commit into from

Conversation

Earlopain
Copy link
Contributor
@Earlopain Earlopain commented May 23, 2025 •
edited
Loading

Related to bundled gems:

  • logger is gone, declare it as a dependency. It's handled on 3.1/main via deprecation/removal of Rack::Logger.
  • ostruct is gone as well. Backport Replace OpenStruct with Struct #2004 and also remove the missed require.

Not sure if you want this. I encountered this during the cgi stuff to get tests to run at all. Since this warns since Ruby 3.4 and no one complained, users are probably ok via dependencies of other gems (or nobody uses this functionality since it is autoloaded). If accepted, I would also backport to 2.0

jeremyevans
jeremyevans reviewed May 23, 2025
View reviewed changes
Copy link
Contributor
@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OpenStruct replacement looks fine.

I don't want to add a dependency on logger when logger is not used by default, only by rack/logger.

@Earlopain Earlopain force-pushed the 3-0-stable-ruby-3.5 branch from 5a9dedf to 33a6b02 Compare May 27, 2025 11:53
@Earlopain
Copy link
Contributor Author

I added both to the gemfile then. I found f52ec9a which also just did the same for base64. I only did this for tests, and adding it to the gemfile is enough for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyevans jeremyevans jeremyevans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Earlopain @jeremyevans
0