Change CGI::Cookie.new to Cookie.new #2335
Conversation
|
Confirmd that this pull request addresses the Rails CI errors https://buildkite.com/rails/rails-nightly/builds/2248#0196ea59-3eab-4a37-bc05-24126a9ad23d/1181-2640 While I see these 3 tests are failing with Ruby 3.5.0dev. $ ruby -v
ruby 3.5.0dev (2025-05-19T17:34:29Z master a7ef9a44a6) +PRISM [x86_64-linux]
$ bundle exec ruby -Itest test/spec_mock.rb
Run options: --seed 35143
# Running:
...........................F.....FF
Finished in 0.023080s, 1516.4772 runs/s, 6932.4670 assertions/s.
1) Failure:
Rack::MockResponse#test_0005_provide access to persistent cookies [test/spec_mock.rb:306]:
--- expected
+++ actual
@@ -1 +1,3 @@
-"persistent_test"
+# encoding: ASCII-8BIT
+# valid: true
+"p"
2) Failure:
Rack::MockResponse#test_0004_provide access to session cookies [test/spec_mock.rb:295]:
--- expected
+++ actual
@@ -1 +1,3 @@
-"session_test"
+# encoding: ASCII-8BIT
+# valid: true
+"s"
3) Failure:
Rack::MockResponse#test_0006_provide access to secure cookies [test/spec_mock.rb:317]:
--- expected
+++ actual
@@ -1 +1,3 @@
-"secure_test"
+# encoding: ASCII-8BIT
+# valid: true
+"s"
35 runs, 160 assertions, 3 failures, 0 errors, 0 skips
$ |
This was also missed in the 2.2-stable backport.
|
Found something else that was missed in the 2.2 backport, and pushed a commit for it. @yahonda, I apologize, but could you please check again and see if the additional commit fixed it? |
|
Confirmed 12195e9 addresses all of failures reported at #2335 (comment) |
|
3-0-stable is also incomplete. It produces the same failures as in #2335 (comment) and needs 12195e9 It also still uses OpenStruct, so there are other failures on 3.5 since it is now gone for good. The same is also true for 2-2-stable. Should that be handled? For reference: #2004 #2166. It's not a problem for rails tests since some other dep pulls it in. |
|
Sorry folks it sounds like I did a poor job back-porting this fix. Let me take a closer look. |
Fixes #2334