Fix: Replace typo + Add error handler in AuthController.js #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo in the Promise parameter from rejecj to reject. Added a proper error handler to the onAuthStateChanged method, this is what it does: Calls unsubscribe() (prevent memory leaks), and properly rejects the promise with the error
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
autoSignInmethod in theAuthControllerclass. Corrects a typo in therejectparameter and adds error handling to ensure the promise is properly rejected if an error occurs during the authentication state change.src/controllers/AuthController.js: Corrected the typo in therejectparameter and added error handling to theautoSignInmethod.Notes:
fix typo in the Promise parameter from rejecj to reject.
Added a proper error handler to the onAuthStateChanged method, this is what it does: Calls unsubscribe() (prevent memory leaks), and properly rejects the promise with the error