8000 Ishikawa tools by Zlatanius · Pull Request #489 · ruxailab/RUXAILAB · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ishikawa tools #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Ishikawa tools #489

merged 6 commits into from
Jun 3, 2024

Conversation

Zlatanius
Copy link
Contributor

In this PR I changed back to using the auto generated GITHUB_TOKEN (from testing on a fork this should work). I've also edited the user and project secrets to ruxailab and RUXAILAB repectivly and added a workflow_dispatch trigger to the action so that it can be tested more easily.

@Zlatanius Zlatanius requested review from jvJUCA and marcgc21 May 30, 2024 19:47
@sergiobeltranguerrero
Copy link
Member

I think the requirements.txt file is missing, because there are libraries like pandas, github, matplotlib and requests that need to be imported.

@Zlatanius
Copy link
Contributor Author
Zlatanius commented Jun 2, 2024

@sergiobeltranguerrero The dependencies are isntalled in the github action, but can add a requirements file for local testing.
EDIT: It's added.

Copy link
sonarqubecloud bot commented Jun 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member
@jvJUCA jvJUCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will accept to test on the repository inputs!

9244

@jvJUCA jvJUCA merged commit 6c3db0a into develop Jun 3, 2024
3 checks passed
@jvJUCA jvJUCA deleted the ishikawa-tools branch June 6, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0